Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No implementation of MockStorageReference.getDownloadURL #10

Closed
ChopinDavid opened this issue Aug 9, 2021 · 1 comment
Closed

No implementation of MockStorageReference.getDownloadURL #10

ChopinDavid opened this issue Aug 9, 2021 · 1 comment

Comments

@ChopinDavid
Copy link

ChopinDavid commented Aug 9, 2021

I've gone ahead and forked this repo and implemented getDownloadURL within MockStorageReference. It seems that there is no way, AFAIK, to construct a download url that is similar to an actual Firebase Storage download URL (https://firebasestorage.googleapis.com/v0/b/{your-application}.appspot.com/o/{url-encoded-path-name}?alt=media&token={your-token}) so I have it returning a dummy value instead (https://firebasestorage.googleapis.com/{path}). This dummy value could be updated so that _path is url encoded when interpolated into the download URL path that the function returns. Also, there could probably also be a test written around this, but I didn't see any Mock Reference tests.

Let me know if you are interested in me creating a PR for my fork.

@OlegNovosad OlegNovosad mentioned this issue Nov 6, 2021
@cedvdb
Copy link
Contributor

cedvdb commented Mar 27, 2022

yes the pr would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants