Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading css through Javascript #35

Open
martinpengellyphillips opened this issue Apr 5, 2013 · 5 comments
Open

Avoid loading css through Javascript #35

martinpengellyphillips opened this issue Apr 5, 2013 · 5 comments

Comments

@martinpengellyphillips
Copy link
Collaborator

Loading the themes CSS through the Javascript possibly complicates things for those trying to override certain styles as the priority of the css cannot be determined. See if just loading it by adding explicitly is viable and update docs to reflect this where appropriate.

@dekristo
Copy link

What is current status of this issue? How can i help?

@martinpengellyphillips
Copy link
Collaborator Author

Hey! This one is currently just lingering around. Feel free to have a go.

Basically you would need to remove the xstyle/css! load directive in dboostrap/main.js and then manually add a link to dbootstrap.css in index.html. If that all works as expected then update the README.rst where appropriate to instruct users to now manually add the dbootstrap.css link to their projects.

@jaetea
Copy link

jaetea commented Aug 28, 2013

I'm working on integrating this in the next couple of months. Its pretty straight foward.

However, don't you still need to load via the xstyle so the dojo icons are replaced with glyphicons?

@martinpengellyphillips
Copy link
Collaborator Author

Shouldn't do, though you would still need to load the dbootstrap package to alter the dom structure of some of the Dojo widgets to work with the icons. Haven't had a chance to try this myself yet though - are you seeing that you do still need the xstyle load?

@slimmtl
Copy link

slimmtl commented Mar 24, 2015

@jaetea have you worked on this?

I get a problem when trying to build with my styles inlined using the plugin: directive. It seems to conflict with dbootstrap,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants