Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken settings on restore when using a . in property names #358

Closed
jpeltoniemi opened this issue May 2, 2017 · 1 comment
Closed

Broken settings on restore when using a . in property names #358

jpeltoniemi opened this issue May 2, 2017 · 1 comment
Labels
Milestone

Comments

@jpeltoniemi
Copy link

The restored settings for package file-types may break when restoring settings.

config.cson:

  "file-types":
    html: "text.html.js"
    "^[^\\.]+$": "source.shell"            (A: Original regex, doesn't work)
    "^[\\w\\d\\-_]+$": "source.shell"      (B: New regex, works)

File-types tries to set proper syntax hilighting according to filename matching rules above.

I previously used regex A to match filenames without a dot but realised sync-settings(or Atom) has a special meaning for dot in property names.

I'm not sure if this is a bug or just how Atom works, but I'm reporting it just in case. I'm also creating an issue to file-types and referencing this one there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants