feat: use self-contained ViewContainer components

atom-community · Oct 9, 2020 · bede650 · bede650
1 parent 8345a5b
commit bede650
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/lib/signature-help-manager.js b/lib/signature-help-manager.js
@@ -5,8 +5,6 @@
 const { CompositeDisposable, Disposable, Range, Point, TextEditor } = require("atom")
 import { ProviderRegistry } from "atom-ide-base/commons-atom/ProviderRegistry"
 import { ViewContainer } from "atom-ide-base/commons-ui/float-pane/ViewContainer"
-import { getDocumentationHtml } from "atom-ide-base/commons-ui/float-pane/HTMLView"
-import { getSnippetHtml } from "atom-ide-base/commons-ui/float-pane/SnippetView"
 import type { MarkdownService } from "atom-ide-base"
 
 module.exports = class SignatureHelpManager {
@@ -254,7 +252,6 @@ module.exports = class SignatureHelpManager {
         this.unmountDataTip()
 
         const grammar = editor.getGrammar().scopeName.toLowerCase()
-        const snippetHtml = await getSnippetHtml([signature.label], grammar, this.renderer)
         let doc = null
 
         if (parameter) {
@@ -268,15 +265,16 @@ module.exports = class SignatureHelpManager {
         } else {
           doc = ""
         }
-        const documentationHtml = await getDocumentationHtml([doc], grammar, this.renderer)
         const signatureHelpView = new ViewContainer({
           snippet: {
-            element: snippetHtml,
+            snippet: signature.label,
+            grammar: grammar,
             containerClassName: "signature-container",
             contentClassName: "signature-snippet",
           },
-          html: {
-            element: documentationHtml,
+          markdown: {
+            markdown: doc,
+            grammar: grammar,
             containerClassName: "signature-marked-container",
             contentClassName: "signature-marked",
           },