Height calculation is off?

[lee-dohm]

Atom v0.167.0-a9c0553 on Mac OS X 10.10.1 using 27" Retina iMac

I also have *.editor.scrollPastEnd enabled.

Apologies in advance for the huge image:

[lee-dohm]

I have the following in my styles.less:

@ui-font-size: 14px;

atom-workspace {
  font-family: 'Helvetica Neue', sans-serif;
  font-size: @ui-font-size;
}

I suspect that with the change in how the minimap is attached to the editor view, this style may now affect the size of the minimap text (which does appear larger) and is therefore throwing off the size calculations.

[abe33]

It shouldn't, minimap is now canvas based, and so is unaffected by font styles. By the look of it it's like the previous version stretching bug on resize window. Have you enabled the v4 preview setting and restarted?

[abe33]

Oh... looks like something retina-related. Sadly I haven't a retina display available for testing, however the code for drawing on the canvas is roughly the same as before. I'll try to find a computer with a retina screen to test that.

[abe33]

Can you tell me what is the size of the canvas inside the atom-text-editor-minimap element in that situation?

[lee-dohm]

Sure ... looks like 200x1832

[abe33]

Ok, it should be a quick fix, the canvas must have a style.width and style.height in addition of width and height attributes.

[lee-dohm]

🍻 Thanks for your help!

[abe33]

If you have some time to try a thing, does the canvas get the correct scale if you specify a width/height in its style attributes with values of half the canvas size?

[lee-dohm]

When I try to override it like you say, it doesn't change anything and I get warning icons in the style viewer:

[abe33]

You should use px unit for the width and height in the style attribute ;)

[lee-dohm]

😊

Yeah, that works.

I always say that CSS isn't my thing! 😆

[abe33]

Yeah, that works.

The change of size to fix the scaling issue or the use of px for width & height?

[lee-dohm]

Both 😀

On Jan 6, 2015, at 9:18 AM, Cédric Néhémie notifications@github.com wrote:

Yeah, that works.

The change of size to fix the scaling issue or the use of px for width & height?

—
Reply to this email directly or view it on GitHub.

[lee-dohm]

Thanks! Confirmed on my machine 👍