allow fractional sizes in minimap #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially useful on retina screens if you want to use the smaller pixels.
|
👍 Thanks for that, I wasn't sure at first if a float would gives good results but I should have thought of HiDPI displays. |
abe33
added a commit
that referenced
this pull request
Feb 16, 2015
🐛 Fix size settings not allowing float numbers
|
Hi, Thanks for the prompt merge, that's awesome! 8-) On 16 February 2015 at 22:49, Cédric Néhémie notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a "retina" screen mac and wanted to make use of the smaller real pixels; currently I have 1 real pixel interline, 3 real pixels char height, and 2 real pixels char width. I also experimented with smaller sizes, but my poor eyesight disagreed.
Anyway, to do that, I needed the character sizes to be fractional – with a devicePixelRatio of 2, I want to use increments of .5. Hence my patch, and hence this pull request.