Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: string.replace is not a function #397

Closed
Nath-sticky opened this issue Oct 29, 2015 · 1 comment
Closed

Uncaught TypeError: string.replace is not a function #397

Nath-sticky opened this issue Oct 29, 2015 · 1 comment

Comments

@Nath-sticky
Copy link

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.0.19
System: Unknown Windows Version
Thrown From: minimap package, v4.15.0

Stack Trace

Uncaught TypeError: string.replace is not a function

At C:\Users\Nat\AppData\Local\atom\app-1.0.19\resources\app.asar\node_modules\underscore-plus\lib\underscore-plus.js:189

TypeError: string.replace is not a function
    at plus.escapeRegExp (C:\Users\Nat\AppData\Local\atom\app-1.0.19\resources\app.asar\node_modules\underscore-plus\lib\underscore-plus.js:189:23)
    at Array.map (native)
    at atom-text-editor-minimap.module.exports.CanvasDrawer.getInvisibleRegExp (C:\Users\Nat\.atom\packages\minimap\lib\mixins\canvas-drawer.coffee:219:23)
    at atom-text-editor-minimap.module.exports.CanvasDrawer.drawLines (C:\Users\Nat\.atom\packages\minimap\lib\mixins\canvas-drawer.coffee:155:24)
    at atom-text-editor-minimap.module.exports.CanvasDrawer.updateCanvas (C:\Users\Nat\.atom\packages\minimap\lib\mixins\canvas-drawer.coffee:34:8)
    at atom-text-editor-minimap.MinimapElement.update (C:\Users\Nat\.atom\packages\minimap\lib\minimap-element.coffee:374:6)
    at C:\Users\Nat\.atom\packages\minimap\lib\minimap-element.coffee:323:8

Commands

     -2:15 fuzzy-finder:toggle-file-finder (atom-pane.pane.active)
     -1:48.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "line-ending-converter",
      "convert-to-utf8"
    ]
  },
  "minimap": {
    "adjustMinimapWidthToSoftWrap": false,
    "absoluteMode": true
  }
}

Installed Packages

# User
minimap, v4.15.0

# Dev
No dev packages
@abe33
Copy link
Contributor

abe33 commented Oct 30, 2015

Hi @NathNioche, thanks for the report. I'm not really sure what happened, as the invisible characters should be strings. I'll add a guard to prevent this error from being raised again.

@abe33 abe33 closed this as completed in f261d5a Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants