Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong render in 1.9.0 beta #502

Closed
hultberg opened this issue Jun 13, 2016 · 4 comments
Closed

Wrong render in 1.9.0 beta #502

hultberg opened this issue Jun 13, 2016 · 4 comments
Labels

Comments

@hultberg
Copy link
Contributor

Hello! I noticed that minimap renders different in Atom 1.9.0. Is this intended?

Atom 1.8.0 Atom 1.9.0
screen shot 2016-06-13 at 21 23 37 screen shot 2016-06-13 at 21 23 30

Using Mac OSX 10.11.5

@abe33 abe33 added the bug label Jun 14, 2016
@abe33
Copy link
Contributor

abe33 commented Jun 14, 2016

Hi @hultberg, it is indeed not intended. There were many important changes in 1.9.0 that required to change how we handle things like whitespace characters and line tokens. In most our tests we didn't see anything wrong (I'm always using a version built upon master), maybe that have to do with the editor or the minimap config, could you share with me your config (editor & minimap)?

@hultberg
Copy link
Contributor Author

@abe33

This is my atom config:

"*":
  "advanced-open-file":
    createDirectories: true
  "atom-ctags":
    cmdArgs: "--exclude=*.js"
  core:
    disabledPackages: [
      "symbols-view"
    ]
    excludeVcsIgnoredPaths: false
    themes: [
      "one-dark-ui"
      "atom-material-syntax-dark"
    ]
  docblockr:
    return_description: false
    spacer_between_sections: true
  editor:
    backUpBeforeSaving: true
    invisibles: {}
    lineHeight: 2.2
    scrollPastEnd: true
    tabLength: 4
    tabType: "soft"
  "fuzzy-finder":
    ignoredNames: [
      ".git"
      "svg/"
      "node_modules/"
    ]
  "linter-jshint": {}
  minimap:
    plugins:
      "find-and-replace": true
      "find-and-replaceDecorationsZIndex": 0
      "git-diff": true
      "git-diffDecorationsZIndex": 0
      "highlight-selected": true
      "highlight-selectedDecorationsZIndex": 0
      "minimap-hide": true
      "minimap-hideDecorationsZIndex": 0
      pigments: true
      pigmentsDecorationsZIndex: 0
      selection: true
      selectionDecorationsZIndex: 0
  pigments: {}
  "split-diff":
    diffWords: true
    ignoreWhitespace: true
    leftEditorColor: "red"
    rightEditorColor: "green"
  welcome:
    showOnStartup: false
".blade.html.php.text":
  editor:
    commentEnd: " --}}"
    commentStart: "{{-- "
".css.source.twig":
  editor:
    tabLength: 4
".html.text.twig":
  editor:
    tabLength: 4
".js.source.twig":
  editor:
    tabLength: 4
".json.source.twig":
  editor:
    tabLength: 4
".source.twig":
  editor:
    tabLength: 4
".source.twig.yaml":
  editor:
    tabLength: 4
".text.twig.xml":
  editor:
    tabLength: 4

Is there a minimap specific config file somewhere?

@abe33
Copy link
Contributor

abe33 commented Jun 14, 2016

Oh, found it! Actually it's because show invisible setting isn't enabled. I'll be looking at how to fix it soon.

Is there a minimap specific config file somewhere?

Nope, it's all under the minimap key in your config, which currently only contains the plugins activations settings.

@abe33 abe33 closed this as completed in 5b762a5 Jun 14, 2016
@hultberg
Copy link
Contributor Author

@abe33 Fix confirmed. After updating and restarting atom (or reloading window) the minimap is rendering correctly. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants