Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on file input elements doesn't show file dialog #454

Closed
obuchtala opened this issue Jul 3, 2014 · 5 comments · Fixed by #777
Closed

Clicking on file input elements doesn't show file dialog #454

obuchtala opened this issue Jul 3, 2014 · 5 comments · Fixed by #777

Comments

@obuchtala
Copy link

In the browser and node-webkit it is possible to trigger file dialogs using input elements.
When I add e.g.

    <input type='file'></input>

to the hello-atom example, atom-shell does not react on clicks onto this element.

Is that considered to be supported someday?
This way, the code for a web-only and a natively embedded version could be kept more similar.

Apart from this, I realise and appreciate the API approach for dialogs.

@as3boyan
Copy link
Contributor

as3boyan commented Jul 4, 2014

@obuchtala
Copy link
Author

Yes, I know the dialog API.

FWIW, in the browser you can use https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement to trigger a native dialog.

My question is if such will be supported or not.

After switching to atom-shell, we need to support two different approaches: one based on the Web File System API and one using atom-shell's and node.js's fs API. And that duality is the focus of this issue.

@zcbenz
Copy link
Member

zcbenz commented Jul 21, 2014

It is currently not supported and will be supported in future.

@jhleath
Copy link

jhleath commented Sep 24, 2014

Does this mean that file dropzones also do not work in Atom Shell, currently? If not, will they be available once file inputs are fixed?

@natevw
Copy link

natevw commented Oct 8, 2014

Interestingly, under v0.16.3 at least, I find the file input element does support dropping a file onto the little broken stub it leaves — filename appears next to broken button, 'change' event fires, my original JS code can .send() the file… so unless I'm basically just seeing the "future support" in progress halfway, I'm having some trouble understanding why just the visual side is broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants