Remove the texteditor isModified/isReadOnly handling intended for uns…

…avable edit buffers as causes issues with vim-mode-plus

spec/text-editor-spec.js

@@ -86,23 +86,6 @@ describe('TextEditor', () => {
     })
   })
 
-  describe('when the editor is readonly', () => {
-    it('overrides TextBuffer.isModified to return false', async () => {
-      const editor = await atom.workspace.open(null, {readOnly: true})
-      editor.setText('I am altering the buffer, pray I do not alter it any further')
-      expect(editor.isModified()).toBe(false)
-      editor.setReadOnly(false)
-      expect(editor.isModified()).toBe(true)
-    })
-    it('clears the readonly status when saved', async () => {
-      const editor = await atom.workspace.open(null, {readOnly: true})
-      editor.setText('I am altering the buffer, pray I do not alter it any further')
-      expect(editor.isReadOnly()).toBe(true)
-      await editor.saveAs(temp.openSync('was-readonly').path)
-      expect(editor.isReadOnly()).toBe(false)
-    })
-  })
-
   describe('.copy()', () => {
     it('returns a different editor with the same initial state', () => {
       expect(editor.getAutoHeight()).toBeFalsy()

src/text-editor.js

@@ -407,7 +407,6 @@ class TextEditor {
             if (this.component != null) {
               this.component.scheduleUpdate()
             }
-            this.buffer.emitModifiedStatusChanged(this.isModified())
           }
           break
 
@@ -568,11 +567,6 @@ class TextEditor {
     this.disposables.add(this.buffer.onDidChangeModified(() => {
       if (!this.hasTerminatedPendingState && this.buffer.isModified()) this.terminatePendingState()
     }))
-    this.disposables.add(this.buffer.onDidSave(() => {
-      if (this.isReadOnly()) {
-        this.setReadOnly(false)
-      }
-    }))
   }
 
   terminatePendingState () {
@@ -1129,7 +1123,7 @@ class TextEditor {
   setEncoding (encoding) { this.buffer.setEncoding(encoding) }
 
   // Essential: Returns {Boolean} `true` if this editor has been modified.
-  isModified () { return this.isReadOnly() ? false : this.buffer.isModified() }
+  isModified () { return this.buffer.isModified() }
 
   // Essential: Returns {Boolean} `true` if this editor has no content.
   isEmpty () { return this.buffer.isEmpty() }