Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Global search results open in new tab *and* new pane #1079

Closed
cobyism opened this issue Nov 5, 2013 · 5 comments
Closed

Global search results open in new tab *and* new pane #1079

cobyism opened this issue Nov 5, 2013 · 5 comments

Comments

@cobyism
Copy link
Contributor

cobyism commented Nov 5, 2013

I personally find it frustrating that the recent switch to global search results opening in a new tab within a new vertically split pane. I only very rarely use split panes, and my main goal when I use global search is just to end up with another tab open in my current pane. When the search results open in a new pane, clicking on a result opens that file in the new pane next to the results, which means that in order to get back to my one-pane setup I now have to drag two tabs back into the original pane.

I actually really liked how the old global search opened results in a drawer up from the bottom. I can handle opening results in a new tab instead, although I think I’d still prefer just a drawer connected to the search fields at the bottom. I can see how the new tab would be helpful so you can close the tab later if/when you need separately from navigating between other files, but going the extra step of creating a new pane for that tab just feels uneccessary and (in my use-case) counterproductive. Is there a good reason for the extra new pane that I’m missing?

@benogle
Copy link
Contributor

benogle commented Nov 5, 2013

Closing in favor of atom/find-and-replace#74

@benogle benogle closed this as completed Nov 5, 2013
@benogle
Copy link
Contributor

benogle commented Nov 5, 2013

Changed to open buffers from the results tab in the left tab in atom/find-and-replace@1944e35

@benogle
Copy link
Contributor

benogle commented Nov 5, 2013

There were a couple reasons I switched them from a drawer to a tab.

  • You couldnt resize the drawer
  • Focus issues. You focus away from the results list, how do you get back without clicking? In the tab it's more clear: just move to the results tab
  • With them in a drawer, you cant find in buffer and see the project results at the same time.

In general, I think it makes interacting with the project find results more intuitive -- it's just like interacting with a buffer, rather than some weird special interface.

@benogle
Copy link
Contributor

benogle commented Nov 5, 2013

All that said, it's certainly not without issues. The split is one of those issues. I really like it being in the right pane, but a lot of others dont split, and it might make sense to put it in the left pane.

@lock
Copy link

lock bot commented Jan 27, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants