"Replace All" should respect selection. It also sho

[atom-bot]

"Replace All" should respect selection. It also shouldn't require one undo for each replacement: They should all be undone in one step.

User: jbarnette
Atom Version: 3053c4a
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_0) AppleWebKit/537.36 (KHTML, like Gecko) Atom/3053c4a Safari/537.36

[benogle]

Do you have the 'in selection' option selected on the find and replace panel? Assuming this is in a single buffer via cmd-f

They should be a single undo step , that must have regressed.

[benogle]

cc @jbarnette. Assumed you're not on the list because no @ in front of your name

[jbarnette]

@benogle Man, I don't know what I was thinking when I typed that. The undo thing was the big deal, but what I actually want is a standard keybinding for "find in selection," which we also don't currently have a command for. Other things I noticed just now:

• cmd-e doesn't work unless the find panel is visible
• man, it'd be great to have a project-wide variant of cmd-e

[benogle]

Noted on both counts. It does actually work when the fnr panel is not shown, but it just doesnt highlight matches when the panel is not shown. So maybe the answer is to pop up the fnr panel when cmd-e is pressed? I'll try it and we can see show it feels.

[jbarnette]

🤘

[jbarnette]

❤️

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!