Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Command palette have 1px missing on border when focused #16903

Closed
skylerlee opened this issue Mar 8, 2018 · 5 comments
Closed

Command palette have 1px missing on border when focused #16903

skylerlee opened this issue Mar 8, 2018 · 5 comments

Comments

@skylerlee
Copy link

skylerlee commented Mar 8, 2018

Prerequisites

Description

I found the Atom's command palette editor have 1px missing on border when focused.

Steps to Reproduce

  1. Open Atom
  2. Press CtrlOrCmd+P
  3. It seems the input palette's blue border have 1px less at top, left and right, here is the screenshot:

screenshot

It seems like a rendering bug because when I move the selection around (pressing up/down),
the missing width get back. But when the palette reopens, it reproduces again.

Versions

Atom : 1.24.0
Electron: 1.6.16
Chrome : 56.0.2924.87
Node : 7.4.0
UI Theme: One-Dark-UI

My Attempting Solution

Set the border-width of the editor seems to solve the problem, but I just wondering the effect of
box-shadow. Can I set it to none?

atom-text-editor[mini].is-focused {
  border-width: 2px;
  box-shadow: none;
}
@Ben3eeE
Copy link
Contributor

Ben3eeE commented Mar 8, 2018

/cc: @simurai

@50Wliu
Copy link
Contributor

50Wliu commented Mar 8, 2018

Fixed.

@50Wliu 50Wliu closed this as completed Mar 8, 2018
@simurai
Copy link
Contributor

simurai commented Mar 9, 2018

Yep, fixed with atom/one-dark-ui#244 that should land in Atom 1.26.

@skylerlee My Attempting Solution

👍 on that solution. In the ☝️ above PR, a 1px padding got added instead. I think the problem is that the backdrop is semi-transparent and causes a rendering glitch of the box-shadow. 🤷‍♂️

@skylerlee
Copy link
Author

Good 👍 , thanks.

@lock
Copy link

lock bot commented Sep 5, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants