Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

READMEs not being rendered correctly on atom.io/packages #22929

Open
mauricioszabo opened this issue Sep 2, 2021 · 3 comments
Open

READMEs not being rendered correctly on atom.io/packages #22929

mauricioszabo opened this issue Sep 2, 2021 · 3 comments

Comments

@mauricioszabo
Copy link

So, recently (I'm not really that sure that's recently, but anyway) I've been unable to reliably update my README on atom.io/package. Yes, it sometimes work, but sometimes don't, the images get all wrong links and I'm not sure why, and the whole thing gets worse when you have a package that is not on GitHub.

For example, here's one example: https://atom.io/packages/simple-git
Here's another: https://atom.io/packages/chlorine

No images appear at all, and they do appear both on Github and on Gitlab's pages. So, how to make it work?

Originally posted by @mauricioszabo in #22904

@sadick254
Copy link
Contributor

@mauricioszabo Thank you for opening this issue. This is now on our radar and we will resolve it as soon as we can.

@mauricioszabo
Copy link
Author

@sadick254 someone already did all the work to fix this: https://github.com/nlydv/atom-io-imgfix/blob/master/js/content.js.

Why not just use it and then solve this issue? Discussions here: #22904

I mean, we could open a PR and solve this upstream, but I don't think that packages site's code is open, right?

@mauricioszabo
Copy link
Author

Can we please see what's happening? The atom.io/packages source code is not at GitHub (so we can't contribute), and this bug that should be easy to fix (I mean, just replace the src at the image to what you're putting in data-canonical-src).

Why the so long delay?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants