Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

0.121.0: font size isn't honored anymore on OS X #3274

Closed
brevilo opened this issue Aug 14, 2014 · 11 comments
Closed

0.121.0: font size isn't honored anymore on OS X #3274

brevilo opened this issue Aug 14, 2014 · 11 comments
Labels
bug mac Issues that occur on macOS but not on other platforms.

Comments

@brevilo
Copy link

brevilo commented Aug 14, 2014

With the update to 0.121.0 Atom doesn't honor the font size setting anymore. All editor content is rendered at about 8 - 10, instead of, say, the default (16). Changing the setting does have an effect on the settings dialog itself, but not in the editor panes.

@brevilo brevilo changed the title 0.121.0: font size isn't honoured anymore 0.121.0: font size isn't honored anymore Aug 14, 2014
@brevilo brevilo changed the title 0.121.0: font size isn't honored anymore 0.121.0: font size isn't honored anymore on OS X Aug 14, 2014
@brevilo
Copy link
Author

brevilo commented Aug 14, 2014

Reverted to 120. All fine again...

@kevinsawicki
Copy link
Contributor

What OS are you using?

@brevilo
Copy link
Author

brevilo commented Aug 14, 2014

See title, OS X 10.9.4

@lee-dohm
Copy link
Contributor

I can't reproduce what you're describing:

fontsizebug

I'm using OS X 10.9.4.

@brevilo
Copy link
Author

brevilo commented Aug 14, 2014

@lee-dohm You are not using the same release apparently. I'm talking about 121, not 122.

@kevinsawicki
Copy link
Contributor

@brevilo What themes are you using?

@brevilo
Copy link
Author

brevilo commented Aug 14, 2014

  • UI: Atom Light
  • Syntax: GitHub Web

@benogle
Copy link
Contributor

benogle commented Aug 15, 2014

It might be a specificity thing with one of your themes. The setting is now applied by a stylesheet, rather than an inline style. So it's really easy to override the setting with css. See

setEditorStyle: (property, value) ->
unless styleNode = atom.themes.stylesheetElementForId('global-editor-styles')[0]
atom.themes.applyStylesheet('global-editor-styles', '.editor {}')
styleNode = atom.themes.stylesheetElementForId('global-editor-styles')[0]
{sheet} = styleNode
editorRule = sheet.cssRules[0]
editorRule.style[property] = value
atom.themes.emit 'stylesheet-updated', sheet
atom.themes.emit 'stylesheets-changed'

Try atom --safe and see if it works there.

@brevilo
Copy link
Author

brevilo commented Aug 16, 2014

When I switch to the Atom Light syntax theme all is fine again, so the GitHub Web syntax theme seems to be in need of an update. I'll open an issue there. So you may close this one.

Thanks

@izuzak
Copy link
Contributor

izuzak commented Aug 16, 2014

Thanks for letting us know

@lock
Copy link

lock bot commented Jan 25, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug mac Issues that occur on macOS but not on other platforms.
Projects
None yet
Development

No branches or pull requests

5 participants