New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.121.0: font size isn't honored anymore on OS X #3274

Closed
brevilo opened this Issue Aug 14, 2014 · 10 comments

Comments

Projects
None yet
5 participants
@brevilo

brevilo commented Aug 14, 2014

With the update to 0.121.0 Atom doesn't honor the font size setting anymore. All editor content is rendered at about 8 - 10, instead of, say, the default (16). Changing the setting does have an effect on the settings dialog itself, but not in the editor panes.

@brevilo brevilo changed the title from 0.121.0: font size isn't honoured anymore to 0.121.0: font size isn't honored anymore Aug 14, 2014

@brevilo brevilo changed the title from 0.121.0: font size isn't honored anymore to 0.121.0: font size isn't honored anymore on OS X Aug 14, 2014

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Aug 14, 2014

Reverted to 120. All fine again...

brevilo commented Aug 14, 2014

Reverted to 120. All fine again...

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Aug 14, 2014

Member

What OS are you using?

Member

kevinsawicki commented Aug 14, 2014

What OS are you using?

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Aug 14, 2014

See title, OS X 10.9.4

brevilo commented Aug 14, 2014

See title, OS X 10.9.4

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Aug 14, 2014

Member

I can't reproduce what you're describing:

fontsizebug

I'm using OS X 10.9.4.

Member

lee-dohm commented Aug 14, 2014

I can't reproduce what you're describing:

fontsizebug

I'm using OS X 10.9.4.

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Aug 14, 2014

@lee-dohm You are not using the same release apparently. I'm talking about 121, not 122.

brevilo commented Aug 14, 2014

@lee-dohm You are not using the same release apparently. I'm talking about 121, not 122.

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Aug 14, 2014

Member

@brevilo What themes are you using?

Member

kevinsawicki commented Aug 14, 2014

@brevilo What themes are you using?

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Aug 14, 2014

  • UI: Atom Light
  • Syntax: GitHub Web

brevilo commented Aug 14, 2014

  • UI: Atom Light
  • Syntax: GitHub Web
@benogle

This comment has been minimized.

Show comment
Hide comment
@benogle

benogle Aug 15, 2014

Contributor

It might be a specificity thing with one of your themes. The setting is now applied by a stylesheet, rather than an inline style. So it's really easy to override the setting with css. See

setEditorStyle: (property, value) ->
unless styleNode = atom.themes.stylesheetElementForId('global-editor-styles')[0]
atom.themes.applyStylesheet('global-editor-styles', '.editor {}')
styleNode = atom.themes.stylesheetElementForId('global-editor-styles')[0]
{sheet} = styleNode
editorRule = sheet.cssRules[0]
editorRule.style[property] = value
atom.themes.emit 'stylesheet-updated', sheet
atom.themes.emit 'stylesheets-changed'

Try atom --safe and see if it works there.

Contributor

benogle commented Aug 15, 2014

It might be a specificity thing with one of your themes. The setting is now applied by a stylesheet, rather than an inline style. So it's really easy to override the setting with css. See

setEditorStyle: (property, value) ->
unless styleNode = atom.themes.stylesheetElementForId('global-editor-styles')[0]
atom.themes.applyStylesheet('global-editor-styles', '.editor {}')
styleNode = atom.themes.stylesheetElementForId('global-editor-styles')[0]
{sheet} = styleNode
editorRule = sheet.cssRules[0]
editorRule.style[property] = value
atom.themes.emit 'stylesheet-updated', sheet
atom.themes.emit 'stylesheets-changed'

Try atom --safe and see if it works there.

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Aug 16, 2014

When I switch to the Atom Light syntax theme all is fine again, so the GitHub Web syntax theme seems to be in need of an update. I'll open an issue there. So you may close this one.

Thanks

brevilo commented Aug 16, 2014

When I switch to the Atom Light syntax theme all is fine again, so the GitHub Web syntax theme seems to be in need of an update. I'll open an issue there. So you may close this one.

Thanks

@izuzak

This comment has been minimized.

Show comment
Hide comment
@izuzak

izuzak Aug 16, 2014

Member

Thanks for letting us know

Member

izuzak commented Aug 16, 2014

Thanks for letting us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment