-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Possible to change the html's bg to be dynamically set on theme apply/change? #4024
Comments
There have been issues in the past on Mac where Atom would flicker on load and/or reload. Setting a default background seemed to fix it, but we have upgraded several chrome versions since this was needed so it may no longer be required. If it is causing issues on certain platforms, I'm totally on board with removing it or tweaking it. If you remove it, do the artifacts go away? |
I'm bleeding edge everything and my default browser is google-chrome-unstable. I didn't see any noticabl performance in Chrome during v36-39, but I upgraded to 40 yesterday and it's been substantially better. WIth that said, Atom has been way more fluid and crisp since I checked out the lastest commit this morning. I notice it now more on app open/close. I could just edit my stylesheet or write a little package; but I thought I would bring it up here. Thanks for the quick response! |
Is there a way you could grab a screenshot or GIF of this happening in Atom? |
Yea give me a few and I'll try to capture it now. However, I've noticed that whenever edge-case bugs like this need to be documented they turn into a unicorn and never appear again ha. Let me see if I can't snap it at the exact right moment or get it in a video screen. It's not a long flash, maybe like 100/200ms; |
Interesting, looks really similar to #929 I wonder if the html background value makes a difference or that trail is from the container window, have you tried removing the style locally from the |
Alright I should have investigated before posting a request for a fix that is non-existant :). I removed the body's white background and set the html's to red and the result was the same as the screen. I also removed the white backgrounds from both the body and html, and the same problem was present. So this is definitely a Chromium issue and not a Atom/AtomShell issue. Google/Chromium refuses to switch to GTK3, So the fix is on them and not Atom. Going past the GTK problems, their frameless apps work even worse. I don't know if it's something with the X server and the way Google does their C++ or what. (If you are on a Mac/Linux and install the Hangouts App, not Hangouts Extension; you/'ll see what I'm talking about in a totally unrelated context to our discussion) Since I started using Atom, it would consistently leave black rectangles or a screen artifact, so I'm actually thankful it's just the white flash. Off topic: I've been fascinated with Hybrid/Portable Webapps since node-webkit debuted; I just thought there were too many visual inconsistencies in how Chromium is approaching it and it's starting to get frustrating. I want to code once, deploy everywhere and then have it look the same everywhere! WIth that said, I've been messing with QT/QML and their frameless and transparent webviews perform better than Chromium's frameless windows. They are also switching to the blink engine in QT5.4 and I was going to see if I couldn't make a cross-platform Polymer GUI Toolkit with it. Thanks again though, hopefully they fix this stuff. It's always the little things that make me go grrr |
Interesting, I wouldn't have thought that. Thanks for the other updates, closing this issue out. |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks! |
System: Arch Linux GNOME 3.14.2 | Linux Kernel 3.17.2 | Lenovo i7, 16gb ram, intel 4000
See it here: https://github.com/atom/atom/blob/2f82fb2ceb5501f2df7e839af467fbfd4bec47ad/static/index.html
On Linux sometimes artifacts are left momentarily on the screen after a resize completes or when closing the app. However this is probably less prevalent in the Mac version because Chromium interacts better with Cocoa than it does w GTK.
This has a been a persistent problem in Chromium since they've gonre to Aura.
Reference bug: https://code.google.com/p/chromium/issues/detail?id=326995&q=linux%20resize%20window&colspec=ID%20Pri%20M%20Iteration%20ReleaseBlock%20Cr%20Status%20Owner%20Summary%20OS%20Modified
The text was updated successfully, but these errors were encountered: