Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAS build still includes private API usage #3232

Closed
cho45 opened this issue Oct 27, 2015 · 5 comments
Closed

MAS build still includes private API usage #3232

cho45 opened this issue Oct 27, 2015 · 5 comments

Comments

@cho45
Copy link

cho45 commented Oct 27, 2015

Mac / electron-v0.34.0-mas-x64

MAS build is uploaded to iTunes Connect successfully. But it is rejected at "in-review" phase with following reason:

The app includes ': _NSDrawCarbonThemeListBox' from the framework '/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit'.

Actually, _NSDrawCarbonThemeListBox is found in Electron Framework with grep.

grep -R _NSDrawCarbonThemeListBox electron-v0.34.0-mas-x64/
Binary file electron-v0.34.0-mas-x64//Electron.app/Contents/Frameworks/Electron Framework.framework/Electron Framework matches
Binary file electron-v0.34.0-mas-x64//Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework matches
Binary file electron-v0.34.0-mas-x64//Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/Electron Framework matches
grep -R _NSDrawCarbonThemeListBox electron-v0.34.0-mas-x64/  5.61s user 0.08s system 99% cpu 5.687 total
@zcbenz
Copy link
Member

zcbenz commented Oct 27, 2015

Thanks for trying out the MAS build, I'll remove the _NSDrawCarbonThemeListBox calls in next release.

@cho45
Copy link
Author

cho45 commented Oct 27, 2015

Thank you. I will try next release.

@lauer3912
Copy link

@cho45 New release, through the MAS review?

@cho45
Copy link
Author

cho45 commented Nov 8, 2015

My app built with electron 0.34.2 is passed and published successfully on MAS.

@lauer3912
Copy link

@cho45 Thank you. can provide you app url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants