Tray - NativeImage using incorrect image for devicePixelRatio @2x

[jstejada]

The issue I'm having is that NativeImage is using a @1x image for the Tray when the window.devicePixelRatio is 2. I am creating my NativeImage by calling NativeImage.createFromPath

I tried to force NativeImage to use the @2x image file by passing in the path to NativeImage.createFromPath that contains *@2x, but it just displays an empty image on the Tray.

If I change the filename of the 2x image to 1x it will display it without scaling. Also, if I just leave the @2x image file on the folder it will display nothing.

Bottom line, it is trying to get the 1x image no matter what even though window.devicePixelRatio is 2.

Is this expected behavior?

[zcbenz]

Can you provide an example?

[jstejada]

hey @zcbenz , so after investigating further it turns out that the problem is with NativeImage.toDataUrl or NativeImage.createFromDataUrl which apparently don't take into account window.devicePixelRatio.

Basically, if i have icon@1x.png and icon@2x.png, and I do:

var tray = new Tray(NativeImage.createFromPath('/some/abs/path/icon.png'));

it will work as expected.

But if I use toDataUrl like this:

var tray = new Tray(
  NativeImage.createFromDataUrl(
    NativeImage.createFromPath('/some/abs/path/icon.png').toDataUrl()
  )
);

it will use @1x always. Is this expected? I need to use toDataUrl.

Im using electron v 0.29.2. I set up an example here: https://github.com/jstejada/electron-tray-icon-example

Thanks!
cc @bengotow

[zcbenz]

@jstejada The data URL doesn't carry scale factor information so nativeImage.createFromDataUrl will always create images with 1x scale factor, I have created a new issue (#3463) for this.