providing option to undock devtools from browser-window #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @_openDevTools() | ||
| BrowserWindow::openDevTools = (options={}) -> | ||
| dock = if options.detach then false else true | ||
| @_openDevTools(dock) |
There was a problem hiding this comment.
I think we can just do @_openDevTools(options.detach).
There was a problem hiding this comment.
since its optional, wouldnt it be better to not pass undefined ? otherwise i have to put up check for it on c++ land right.
There was a problem hiding this comment.
Ah I forgot that.
I think we can do options.detach ?= false before calling @_openDevTools, this matches the style of how we do with default options in other places.
deepak1556
force-pushed
the
api_windows_patch
branch
from
eee40ab
to
7ccfda4
Compare
deepak1556
force-pushed
the
api_windows_patch
branch
from
7ccfda4
to
69d958b
Compare
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Mar 27, 2015
providing option to undock devtools from browser-window
|
Looks like this should be applied to the webview tag devTools as well? |
|
@krainboltgreene |
|
Is there a particular reason it isn't wrapped in a BrowserWindow? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135