Improvements in BrowserWindow

[evgenyzinoviev]

• movable option supported on Windows
• added methods setMovable, isMovable
• added options minimizable, closable and corresponding methods setMinimizable, isMinimizable, setClosable, isClosable. Implemented on Windows and OS X. This options controls whether specific window button and feature should be disabled or enabled.
• On Windows implemented similar to OS X behaviour when fullscreen option is set to false. In this case the maximize button will be disabled.
• Fixed a bug on OS X when resizable is set to false but the zoom button was not disabled when window is created
• Fixed a bug on OS X when if you do win.setResizable(false); win.setResizable(true); win.setResizable(false), the zoom button was not disabled after the second setResizable(false) call

[sbruchmann]

I’m not a Windows user, but I don’t think that disabling fullscreen should disable maximizing windows.

[evgenyzinoviev]

@sbruchmann Well, I agree that this is a bit strange. It's also a little strange to me how fullscreen option works on OS X. Another way is to add maximizable option for Windows.

[xywz]

Could you add setFullscreenable and isFullscreenable?

[evgenyzinoviev]

I'm afraid that fullscreenable will be easily confused with fullscreen. Moreover, "fullscreen" and "maximize" are different concepts. I think that adding maximizable option and setMaximizable and isMaximizable methods would be better solution. We could also improve API for OS X, make it more logical and clear.

Who are the maintainers here? I only know that @zcbenz is. What does he think?

[xywz]

The reason for fullscreenable or a different name is to separate entering/exiting fullscreen from enabling/disabling fullscreen. It will improve the fullscreen API, making it more consistent, logical, and clear. This is unrelated to maximize.

[evgenyzinoviev]

Now I understand. You suggest this for OS X, right?

[xywz]

Right.

[zcbenz]

@evgenyzinoviev Adding fullscreenable and maximizable looks good to me, this PR is awesome!

[kevinsawicki]

I'm a little unsure whether closable or closeable is the right word here.

From a little googling, it looks like Java uses closeable

[zcbenz]

Cocoa uses closable: there is a NSClosableWindowMask flag.

Probably just use the shorter one.

[kevinsawicki]

Probably just use the shorter one.

Sounds good 👍

[kevinsawicki]

@evgenyzinoviev @zcbenz This will fix #2970 right?

[evgenyzinoviev]

@kevinsawicki Yes. I'm gonna finish this tomorrow.

[evgenyzinoviev]

Added the fullscreenable and maximizable options and methods.

[zcbenz]

Thanks!

[petercunha]

Thank you for adding this, much appreciated ❤️