Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add the commit box #17

Closed
benogle opened this issue Feb 18, 2016 · 2 comments
Closed

Add the commit box #17

benogle opened this issue Feb 18, 2016 · 2 comments
Assignees

Comments

@benogle
Copy link
Contributor

benogle commented Feb 18, 2016

screen shot 2016-02-18 at 2 13 50 pm

- Dont need to do anything special in the editor for summary and description. Convention that every other git editor uses: first line summary, blank line, other lines are description. - Use the [git grammar](https://github.com/atom/language-git) in this editor for dopeness - The grammar could probably be improved for our usecase - Initial pass doesnt need to have counter, but it would be cool. Prolly just a div overlay? - Maybe counter is unnecessary due to the grammar. Will likely be clearer after using the grammar cc @simurai - Using text-editors as textareas kind of sucks right now. See https://github.com/atom/atom/issues/5503 One might be inclined to do that work as part of this, or shortly before / after.
@joshaber joshaber added this to the 1: Efficient Committing milestone Feb 22, 2016
@simurai
Copy link
Contributor

simurai commented Feb 23, 2016

Using text-editors as textareas kind of sucks right now.

It would also use the syntax background and colors, which might look out of place in certain theme combos. There might also be issue when enabling/disabling "line breaks", or "scroll past end" etc.

Initially I was thinking that the commit message should have a bigger font than the description. Is there any downside of using a normal <input> and <textarea>? Well, except that the git grammar does't work, but maybe that's ok. Counter could be added at some point.

It could be this:

screen shot 2016-02-23 at 8 07 07 pm

or styled so they look connected:

screen shot 2016-02-23 at 8 06 47 pm

Then the expectation is to use tabs to jump from the input to the textarea and commit button.

Also, the <textarea> could be disabled until you type a commit message:

screen shot 2016-02-23 at 8 21 12 pm

@joshaber joshaber self-assigned this Feb 23, 2016
@benogle
Copy link
Contributor Author

benogle commented Feb 23, 2016

It would also use the syntax background and colors, which might look out of place in certain theme combos. There might also be issue when enabling/disabling "line breaks", or "scroll past end" etc.

Yeah, these issues are definitely part of why it sucks right now.

Is there any downside of using a normal <input> and <textarea>

The best part about using an atom text editor is that all of your movement commands match the editor. Also the ability to use a grammar is a huge win IMO, as we can do much richer things than just enforcing a line length.

I think regardless of whether or not the boxes are separate or attached, they should be atom text editors. We just need to do the work to make text editors nice for use in packages.

Also, I'm of the opinion that the summary and description should be one box. I think it's consistent with other commit editors (e.g. vim or anything you set GIT_EDITOR to, gitx, etc), and I think it slightly reduces friction when moving between the summary and description (just use arrow keys!).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants