Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

GitHub Plugin does not remember token #957

Open
KINFOO opened this issue Jun 20, 2017 · 13 comments
Open

GitHub Plugin does not remember token #957

KINFOO opened this issue Jun 20, 2017 · 13 comments

Comments

@KINFOO
Copy link

KINFOO commented Jun 20, 2017

Prerequisites

Description

GitHub plugin asks for a token at every startup.

Steps to Reproduce

  1. Open Atom
  2. Open a file from a GitHub repository
  3. Toogle GitHub pannel

  4. Click Login

  5. Provide token
  6. Login is successful
  7. PR content is available
  8. Restart Atom
  9. GitHub pannel asks for token, again

Expected behavior:

GitHub plugin remembers token.

Reproduces how often:

100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

$ atom --version
Atom    : 1.18.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0
$ uname -a
Linux hendrix 4.9.0-3-amd64 #1 SMP Debian 4.9.30-2 (2017-06-12) x86_64 GNU/Linux
@KINFOO KINFOO changed the title GitHub Plugin does not remeber token GitHub Plugin does not remember token Jun 20, 2017
@hamza
Copy link

hamza commented Jun 20, 2017

A similar issue is happening with me too. Put it up on the forum

@hamza
Copy link

hamza commented Jun 20, 2017

Try this as a solution #457

Worked for me to use

brew install git

It appears the macOS native git doesn't play well with this package

@BinaryMuse
Copy link
Contributor

BinaryMuse commented Jun 20, 2017

@KINFOO On Linux, we rely on libsecret to remember this token (via keytar). Do you have a keyring manager installed?

Also, if you look in the developer tools, do you see a warning saying "Using an InMemoryStrategy strategy for storing tokens"?

@BinaryMuse
Copy link
Contributor

@hamzatayeb Your issue is not the same; it looks like it might be a duplicate of #861

@KINFOO
Copy link
Author

KINFOO commented Jun 22, 2017

@hamzatayeb I am running Linux,
I think brew won't help.
But thanks

@KINFOO
Copy link
Author

KINFOO commented Jun 22, 2017

$ apt search libsecret
...
libsecret-1-0/stable,now 0.18.5-3.1 amd64  [installé, automatique]
  stockage secret

@BinaryMuse libsecret is installed.
In the console, I read:

Using an InMemoryStrategy strategy for storing tokens. The tokens will only be stored for the current window

I am using KDE Plasma, I think my keyring manager has issues.
It asks me for Git password at computer startup.
Looks like configuring ksshaskpass is a pain, a KDE Wallet pain.

Thanks for the valuable help

@hamza
Copy link

hamza commented Jun 22, 2017

@KINFOO ah yeah sorry about that. Good luck

@KINFOO
Copy link
Author

KINFOO commented Jun 22, 2017

@BinaryMuse I fixed the ksshaskpass issue.

Now, when I start my computer, I am no longer asked for password.
I can navigate to some private repository and perform a fetch without providing password.

Still when I provide Atom a token, it still does not remember it.
Console still displays:

Using an InMemoryStrategy strategy for storing tokens. The tokens will only be stored for the current window

Hope it helps

@jvican
Copy link

jvican commented Mar 30, 2018

I'm having the same problem in Linux, but the console doesn't display anything. I have gnome-keyring installed, so I don't see why it doesn't work.

Could someone give me some pointers to further debug what's going on?

@maxsupermanhd

This comment has been minimized.

@ajjr1996
Copy link

Same issue here

@l4tte
Copy link

l4tte commented Apr 3, 2020

Hey guys! You have to install gnome-keyring because the default one on my system (Arch) is broken with atom. In order to install gnome-keyring on a non-gnome WM, use the PAM method

@EmmanuelLM
Copy link

Same issue here but using Atom under ChromeOs (via Linux emulation).
Would be good to not make the solution dependent on a GUI component (appreciate this is probably a minority of use cases)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants