Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

iconUrl should accept local files #73

Closed
romaincointepas opened this issue Oct 29, 2015 · 7 comments
Closed

iconUrl should accept local files #73

romaincointepas opened this issue Oct 29, 2015 · 7 comments

Comments

@romaincointepas
Copy link

setupIcon does accept a local .ico file, is there any reason why it can't be the same for iconUrl (which should just be named icon then)?

@anaisbetts
Copy link
Contributor

If you use a local .ico file, it'll only work on your computer - the Squirrel installer downloads the icon for the uninstaller on-install. This isn't ideal, but it's how it works right now

@d9k
Copy link

d9k commented Mar 2, 2016

If you use a local .ico file, it'll only work on your computer

So why can't icon be distributed with application package?

the Squirrel installer downloads the icon for the uninstaller on-install

Why can't icon be integrated into installer?

@anaisbetts
Copy link
Contributor

Because IconURL is a URL, and if you specify things that aren't URLs, NuGet will blow up. I suppose we could try a file: URL but that'd be quite unintuitive for people

@lipis
Copy link

lipis commented Mar 2, 2016

@paulcbetts anything.. as long as we can assign some sort of icon to local path :)

@havenchyk
Copy link
Contributor

Well, it's not possible right now because of nuget limitations. Feel free to open issue agains nuget or squirrel.windows.

@mor-o
Copy link

mor-o commented Nov 24, 2022

can we reopen this? this is still an issue on private networks with no access to the internet
NuGet fixed their issue already long ago: NuGet/Home#352

@FrahHS
Copy link

FrahHS commented Aug 15, 2023

can we reopen this? this is still an issue on private networks with no access to the internet NuGet fixed their issue already long ago: NuGet/Home#352

Same issue on local network

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants