Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Scope variables in expressions #221

Open
JacksonKearl opened this issue Jan 20, 2020 · 3 comments
Open

Scope variables in expressions #221

JacksonKearl opened this issue Jan 20, 2020 · 3 comments

Comments

@JacksonKearl
Copy link

Summary

It would be helpful to add a scope to the textmate grammar denoting variable read/write access. For example in typescript, the scope variable.other.readwrite is applied.

Motivation

Currently the only scope given to variable read/write access is source.java, which means users and themes cannot configure the appearance of these accesses in themes.

Additional context

Screen Shot 2020-01-19 at 4 12 55 PM

https://www.reddit.com/r/vscode/comments/equyio/im_using_the_horizon_theme_in_vscode_why_do_local/

@sadikovi sadikovi changed the title Scope for variable read/write access. Scope variables in expressions Jan 21, 2020
@sadikovi
Copy link
Contributor

No, we don't do that currently. Can you give examples when it is useful?

@JacksonKearl
Copy link
Author

Currently the only scope given to variable read/write access is source.java, which means users and themes cannot configure the appearance of variable uses in themes.

Many themes attempt to control variable colors, and they should be able to work in Java in addition to other languages.

@sadikovi
Copy link
Contributor

Okay, makes sense. I am a bit snowed under at the moment due to bunch of other open-source work, would appreciate a pull request :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants