Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Opening and closing tags on the same line aren't matched. #138

Closed
DamnedScholar opened this issue Jun 1, 2016 · 1 comment
Closed

Opening and closing tags on the same line aren't matched. #138

DamnedScholar opened this issue Jun 1, 2016 · 1 comment
Labels

Comments

@DamnedScholar
Copy link

A thread has come up on the forum that points out that <?php ... ?> doesn't get matched as PHP code when on the same line. I did a little bit of poking around and found that the embedded whitespace pattern has a negative lookahead (?![^?]*\\?>) that, when removed, allows single-line PHP comments to display. The thing is, I can't figure out what that negative lookahead was put there to check against. My fork of this package seems to work just fine.

Does anybody know what the negative lookahead was meant to guard against?

@50Wliu
Copy link
Contributor

50Wliu commented Jun 9, 2017

Unable to reproduce:
php-single-line

The thread you're referencing looks like a problem with PHP-in-JavaScript that was fixed in Atom 1.12.0.

@50Wliu 50Wliu closed this as completed Jun 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants