-
Notifications
You must be signed in to change notification settings - Fork 118
Coloring/Highlighting Issues for Exceptions and Constants in PHP #390
Comments
@alexr00, I'm going to need a bit of direction that's a bit more clear here if that's alright. I've now had a chance to get back to this and research your comments because I didn't have any idea what it all meant when you sent it originally. I followed the links when you first posted and none of them were related to VSCode, so I put them aside to research when I had some time. I don't know why this got moved here, I don't use atom, and I don't have it installed on my machine. If you're asking, have I run VSCode bare bones without extensions to check if I can reproduce the error, the answer is yes, the errors still happen. If you're asking if there are extensions that do what I'm asking, I've looked extensively. Further, the highlighting is correct for everything I've encountered in the language except for the specific items I've listed above. I've also searched for other items in the comments and in the already submitted issues for VSCode to see if there was anything that matched. I did that before I posted the issue. After about 1/2 hour of searching and reading, I concluded that if they did exist, they were buried somewhere. Please advise, as I have no idea where to go from here. The fact that it was closed almost immediately also kind of threw me for a loop. Also, I don't think I can edit your comment to place an X on the lines. |
@eeasoftware I moved the issue here because this is the repository where VS Code gets it's grammar for PHP from. The grammar is used for syntax highlighting. There is no action needed from you, thank you though! |
@alexr00 That makes a ton of sense. Thank you for clarifying that. I want to help make things work, but I had no idea where to go from here. |
Prerequisites
Description
Steps to Reproduce
example: catch (\Namespace\Exception1 | \Namespace\Exception2 | \Namespace\Exception3 $e) {...}
example: public static function redirect(string $locationUri, array $responseCode = \Http\Response\Code::SEE_OTHER, array $additionalRedirectHeaders = []): void
example: public const STRING = 2;
Expected behavior:
Actual behavior:
Reproduces how often:
Versions
Version 0.44.4 from commit 882f6c0
Additional Information
Originally from @eeasoftware in microsoft/vscode#95559
The text was updated successfully, but these errors were encountered: