Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Doesn't detect todo in // type comments in stylus files #33

Closed
zenopopovici opened this issue Aug 12, 2015 · 8 comments
Closed

Doesn't detect todo in // type comments in stylus files #33

zenopopovici opened this issue Aug 12, 2015 · 8 comments

Comments

@zenopopovici
Copy link

Eg.

[... Code ...]

// TODO: Blahblah

[... Code ...]

Is this intentional?

@kevinsawicki
Copy link
Contributor

What language was the code in that you aren't seeing it highlight in?

@zenopopovici
Copy link
Author

This only happens in stylus files. I've tested across some other files.

@zenopopovici zenopopovici changed the title Doesn't detect todo in // type comments. Doesn't detect todo in // type comments in stylus files Aug 13, 2015
@vchynarov
Copy link

This also does not work in Scala files.
// TODO HACK REVIEW
is not highlighted.

@nixel2007
Copy link

Doesn't work for language-1c-bsl files too.
Is there something, that is needed to add in the "parrent" grammar to make things work?

@mcrawshaw
Copy link

mcrawshaw commented May 14, 2016

Same behaviour in typescript (either .ts or .tsx files)

@asifm
Copy link

asifm commented Jun 26, 2016

Doesn't' work in markdown (source.gfm) either.

@50Wliu
Copy link
Contributor

50Wliu commented Jun 26, 2016

Having just fixed this in language-coffee-script, I can share some things that need to be done in order for TODO highlighting to work correctly.

The comment matches cannot be a simple match regex, eg match: '(#).*$', as that won't allow language-todo to inject itself in that match. Instead, it has to be a begin/end pattern.
atom/language-coffee-script@ad0aa55

As this is most likely a problem with individual grammar files and not language-todo itself, I'm closing this.

@50Wliu 50Wliu closed this as completed Jun 26, 2016
@nixel2007
Copy link

@50Wliu thanks a lot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants