Black/dark design?

[rugk]

I'd like to use a black design for the markdown preview. (otherwise this is just a too strong contrast)

I've tried it with this simple CSS tweak, but it does not really looks such nice and it seems I have to adjust much more:

.markdown-preview {
  color: #ffffff;
  background-color: #000000;
}

E.g. tables are still white and I don't really need such a dark black.

In #293 (comment) I've seen @hemraker uses one.
I think at least you, @hemraker, have a nicer solution for this.

[hemraker]

I use One Dark Ui and syntax theme. Simple as that :)

[rugk]

Strange. I've also used One Dark syntax but another UI theme.
So after changing both to One Dark it worked (obviously), so I've tried and changed the UI theme back (leaving one dark as syntax like it always was) and it stayed dark... 😕

So I've changed the (build-in) syntax themes again and even the 'light' themes always displayed a dark background (although the quote part was light now).
So maybe the style was not applied as I (as far as I can remember) didn't changed it after installing this package. (It was really just black text on a white background)
Could this be the issue? So the style just was not applied...

[hemraker]

That sounds very likely. I don't think changing the theme overwrites the css you've written in styles.less but to be honest I haven't played too much around with it as I've been really satisfied with One Dark.

[rugk]

Ehm... you're right, yes.
Just noticed that I still had the overwrites in my stylesheet... Dump... 🙉

Now it looks better, but it seems that the UI theme is important. Only with One dark (UI) it was dark. With Atom dark it wasn't, no matter what syntax theme I choose.

[rugk]

And this really does not look nice:

(code: https://gist.github.com/rugk/099e2b793d907c9ee46e)

[hemraker]

I couldn't agree more 😄
Seems that UI influences menus, toolbars and markdown-preview Syntax is just the editor.

Glad you got it fixed!!

[rugk]

Well... fixed. I still do not want to use the One dark.

But I've now opened an issue at the UI repo: atom/atom-dark-ui#50

[simurai]

I think it's worth trying to make this package adapt to the syntax colors. Then not every theme has to do the same.

[rugk]

Okay, so back here.
Just make sure to not override this option.

[simurai]

Just make sure to not override this option.

Yes, that should stay.

WIP. One dark:

Atom dark:

[rugk]

The screenshots already look very promising. Any news here?

[simurai]

@rugk Ok, this should be in the next release.

[rugk]

Nice... 👍