New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicate plan on how to modify metrics to be opt-in now that 1.0 is released #52

Closed
lee-dohm opened this Issue Jul 1, 2015 · 13 comments

Comments

Projects
None yet
10 participants
@lee-dohm
Member

lee-dohm commented Jul 1, 2015

Per our conversation related to #16, please let us know what the team's thoughts are on how to make metrics be opt-in now that Atom is out of Beta. Let us know if there is any information or feedback from the community the Atom team needs to make the best decision!

Thanks!

@yukulele

This comment has been minimized.

Show comment
Hide comment
@yukulele

yukulele commented Jul 10, 2015

👍

@blobgo

This comment has been minimized.

Show comment
Hide comment
@blobgo

blobgo Jul 31, 2015

👍

But to make it really 'uncreepy' you would have to get rid of Google Analytics and use Piwik instead. This data is still saved on Google servers, so unless you switch to an open source tracking service on your own server it is creepy.
(See issue #43)

blobgo commented Jul 31, 2015

👍

But to make it really 'uncreepy' you would have to get rid of Google Analytics and use Piwik instead. This data is still saved on Google servers, so unless you switch to an open source tracking service on your own server it is creepy.
(See issue #43)

@yonas

This comment has been minimized.

Show comment
Hide comment
@yonas

yonas Aug 31, 2015

I'm shocked that this is not opt-in....

I found out that Atom was sending reports to Google by reading the Wikipedia article. I doubt most people will be doing that.

yonas commented Aug 31, 2015

I'm shocked that this is not opt-in....

I found out that Atom was sending reports to Google by reading the Wikipedia article. I doubt most people will be doing that.

@itay-grudev

This comment has been minimized.

Show comment
Hide comment
@itay-grudev

itay-grudev Sep 5, 2015

Contributor

Guys, it's a plugin after all. You can just disable it.

P.S. I just made a pull-request modifying the SHA-1 hash of the MAC address to SHA-256 and I verified that the code that sends the HTTPS request sends either a random UUID v4 or a SHA-1 (though this should be updated), so in both cases your anonymity is (SHA1)preserved.

Contributor

itay-grudev commented Sep 5, 2015

Guys, it's a plugin after all. You can just disable it.

P.S. I just made a pull-request modifying the SHA-1 hash of the MAC address to SHA-256 and I verified that the code that sends the HTTPS request sends either a random UUID v4 or a SHA-1 (though this should be updated), so in both cases your anonymity is (SHA1)preserved.

@blobgo

This comment has been minimized.

Show comment
Hide comment
@blobgo

blobgo Sep 5, 2015

@yonas How is atom sending reports to Google via Wikipedia!?

No, he meant something else:

I found out that Atom was sending reports to Google by reading the Wikipedia article.

blobgo commented Sep 5, 2015

@yonas How is atom sending reports to Google via Wikipedia!?

No, he meant something else:

I found out that Atom was sending reports to Google by reading the Wikipedia article.

@blobgo

This comment has been minimized.

Show comment
Hide comment
@blobgo

blobgo Sep 5, 2015

P.S. I just made a pull-request modifying the SHA-1 hash of the MAC address to SHA-256 and I verified that the code that sends the HTTPS request sends either a random UUID v4 or a SHA-1 (though this should be updated), so in both cases your anonymity is (SHA1)preserved.

It's still a MAC address, which can be brute-forced quite easily.

blobgo commented Sep 5, 2015

P.S. I just made a pull-request modifying the SHA-1 hash of the MAC address to SHA-256 and I verified that the code that sends the HTTPS request sends either a random UUID v4 or a SHA-1 (though this should be updated), so in both cases your anonymity is (SHA1)preserved.

It's still a MAC address, which can be brute-forced quite easily.

@blobgo

This comment has been minimized.

Show comment
Hide comment
@blobgo

blobgo Sep 5, 2015

@yonas Where does that happen. Repo/File/Line. Let's hunt it down and fix it!

Eh, what? 😕 Atom is sending reports to Google - that's the whole idea of this package. It's Google Analytics...

blobgo commented Sep 5, 2015

@yonas Where does that happen. Repo/File/Line. Let's hunt it down and fix it!

Eh, what? 😕 Atom is sending reports to Google - that's the whole idea of this package. It's Google Analytics...

@yonas

This comment has been minimized.

Show comment
Hide comment
@yonas

yonas Sep 6, 2015

@itay-grudev blobgo is right, this package isn't broken, so there's nothing to fix in this package.

What we need to do is make this package not enabled by default.

yonas commented Sep 6, 2015

@itay-grudev blobgo is right, this package isn't broken, so there's nothing to fix in this package.

What we need to do is make this package not enabled by default.

@COLABORATI

This comment has been minimized.

Show comment
Hide comment
@COLABORATI

COLABORATI Sep 14, 2015

Please repost about the ongoing efforts of this issue to the interested public, thanks!

COLABORATI commented Sep 14, 2015

Please repost about the ongoing efforts of this issue to the interested public, thanks!

@chpio

This comment has been minimized.

Show comment
Hide comment
@chpio

chpio commented Feb 15, 2016

+1

@n1trux

This comment has been minimized.

Show comment
Hide comment
@n1trux

n1trux Mar 29, 2016

I think the solution in #41 is quite a good one for the time being. Please review this.

n1trux commented Mar 29, 2016

I think the solution in #41 is quite a good one for the time being. Please review this.

@damieng

This comment has been minimized.

Show comment
Hide comment
@damieng

damieng Aug 2, 2016

Contributor

All users both new and existing/upgrades will be prompted to make a choice with regards to telemetry as shown in the screenshot at atom/atom#12281

There isn't a separate option for exception-reporting as multiple options would likely confuse the issue further. If you wish to allow exception-reporting but not metrics then you could opt-in and disable the metrics package.

Contributor

damieng commented Aug 2, 2016

All users both new and existing/upgrades will be prompted to make a choice with regards to telemetry as shown in the screenshot at atom/atom#12281

There isn't a separate option for exception-reporting as multiple options would likely confuse the issue further. If you wish to allow exception-reporting but not metrics then you could opt-in and disable the metrics package.

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Aug 8, 2016

Member

Since @damieng posted the plan, I'm going to close this 😀

Member

lee-dohm commented Aug 8, 2016

Since @damieng posted the plan, I'm going to close this 😀

@lee-dohm lee-dohm closed this Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment