Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

migrate to GitHub Actions for building and publishing releases #320

Closed
1 of 3 tasks
shiftkey opened this issue Nov 2, 2020 · 5 comments · Fixed by #334
Closed
1 of 3 tasks

migrate to GitHub Actions for building and publishing releases #320

shiftkey opened this issue Nov 2, 2020 · 5 comments · Fixed by #334

Comments

@shiftkey
Copy link
Contributor

shiftkey commented Nov 2, 2020

Looks like travis-ci.org is being closed down at the end of the year, and projects are being migrated to travis-ci.com.

While a free tier remains on travis-ci.com it seems this may quickly consume the free credits when having to build each on macOS, Windows and Linux for a run.

Let's take this opportunity to get a simple Actions workflow setup:

Open questions:

@dennisameling
Copy link
Contributor

dennisameling commented Nov 8, 2020

Regarding publishing to NPM on a new tag: here's a GH Actions workflow for a different repo where I did that (your scenario might be a bit more complex I guess): https://github.com/dennisameling/muuri-angular/blob/master/.github/workflows/npm-publish.yml

On tag, build & publish to GitHub: here's a repo where I did that for an open source marketing automation tool: https://github.com/mautic/mautic/blob/staging/.github/workflows/release.yml#L53-L86

This action allows you to upload multiple release assets at once: https://github.com/marketplace/actions/upload-release-assets

Not sure if this helps at all, just wanted to share this for inspiration! Let me know if I can be of any help in this process 🚀

Side note: Electron arm64 should keep working as the current Travis config only uses a x64 host, so it cross-compiles stuff somehow.

@vladimiry
Copy link

vladimiry commented Dec 18, 2020

Is there specific reason for having ubuntu-16.04 in the config file but not 18.04 or 20.04? If this is about setting up gnome-keyring I think I could help here since was recently handling the task in https://github.com/vladimiry/ElectronMail.

@shiftkey
Copy link
Contributor Author

@vladimiry the Travis build was running 16.04 so I think that's why I stuck with that version, but I think this was also related to python-gnomekeyring - there's more context in this discussion about upgrading but I left it as there were more pressing things to tackle at the time https://askubuntu.com/questions/1080896/what-replaced-pythons-gnomekeyring-module-in-ubuntu-18-04-bionic

@vladimiry
Copy link

Ok, going to make a PR soon.

@vladimiry
Copy link

The PR is #342.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants