Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Too Much Red Syntax Highlighting? #60

Closed
lukeschunk opened this issue Jan 14, 2016 · 11 comments
Closed

Too Much Red Syntax Highlighting? #60

lukeschunk opened this issue Jan 14, 2016 · 11 comments

Comments

@lukeschunk
Copy link

I opened Atom today and noticed that my page had a LOT of red on it. I know this wasn't how it was before. For example, in the screenshot, this.props.isLoading should not be all red. I believe only the this was red before?

Any thoughts?
screen shot 2016-01-14 at 2 09 05 pm
screen shot 2016-01-14 at 2 10 31 pm

@50Wliu
Copy link

50Wliu commented Jan 14, 2016

@50Wliu 50Wliu closed this as completed Jan 14, 2016
@50Wliu 50Wliu added duplicate and removed feedback labels Jan 14, 2016
@lukeschunk
Copy link
Author

Fair, but any idea why this would have happened suddenly? I didn't even update today.

@50Wliu
Copy link

50Wliu commented Jan 14, 2016

@lukeschunk Atom 1.4.0 was released yesterday, containing many language-javascript changes. Your Atom probably automatically updated when you closed it.

@lukeschunk
Copy link
Author

ahh thank you so much that must have been it @50Wliu

@RiCoTeRoX
Copy link

Hi @lukeschunk ,
I changed these classes to have the old styles, maybe it help you

atom-text-editor::shadow span.meta.method-call.js > span.variable.other.object.js {
color: #abb2bf;
}
atom-text-editor::shadow span.meta.method-call.js > span.entity.name.function.js {
color: #abb2bf;
}

atom-text-editor::shadow span.meta.method-call.js > span.variable.other.property.js {
color: #abb2bf;
}

atom-text-editor::shadow span.source.js > span.variable.other.property.js {
color: #abb2bf;
}

@marcelombc
Copy link

Revert to version to 0.100.0 or add this styles:

@import 'colors';

atom-text-editor::shadow {
    .variable.other.object.js { color: @mono-1; }
    .variable.other.property.js { color: @mono-1; }
    .meta.method-call.js {
        > .entity.name.function.js { color: @mono-1; }
    }
    .meta.function-call.js {
        > .entity.name.function.js { color: @mono-1; }
    }
}

@MaximSokolov
Copy link

@RiCoTeRoX, @marcelombc to revert changes properly add this:

@import "syntax-variables";

// Replace `.theme-one-dark-syntax` with `.theme-{syntax theme name}`
.theme-one-dark-syntax atom-text-editor::shadow .source.js {
  .variable.other.property, .variable.other.object {
    color: @syntax-text-color;
  }

  .meta.function-call, .meta.method-call {
    & > .entity.name.function {
      color: @syntax-text-color;
    }
  }
}

@marcelombc
Copy link

@MaximSokolov thank you.

@lukeschunk
Copy link
Author

👍 awesome thanks everyone

@RiCoTeRoX
Copy link

thank you @MaximSokolov !

@preschian
Copy link

@MaximSokolov thank you~

still love the old one...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants