Skip to content
This repository has been archived by the owner on Sep 7, 2018. It is now read-only.

Add option to switch tab close button to the left side #202

Closed
jerrykal opened this issue Apr 13, 2017 · 3 comments · Fixed by #253
Closed

Add option to switch tab close button to the left side #202

jerrykal opened this issue Apr 13, 2017 · 3 comments · Fixed by #253

Comments

@jerrykal
Copy link

jerrykal commented Apr 13, 2017

Like Safari.

close-button-on-the-left-side

@simurai
Copy link
Contributor

simurai commented Apr 18, 2017

We were thinking about it: #95

It got closed with: ...wait for 2.0 where "breaking" changes are more ok.

But that was a while ago and we might can reconsider since there aren't any plans for 2.0 yet.

@partydrone
Copy link

I was just reviewing the comments from #95—including mine. Since that time, I think I land squarely on the "native experience" side of the argument for this particular issue.

Considering the idea "muscle memory," I develop solely on a Mac, so I expect the close icon to be on the left side—that's where it is for everything else, and that's where my muscle memory takes me (when I use the mouse). Any app that doesn't do that (i.e., Chrome) calls attention to itself.

For "consistency across platforms," I think there's a certain amount of context to consider. No app exists entirely on its own. It lives in an environment created by the operating system it runs on. That operating system defines rules and sets expectations for its users. Apps that don't follow those rules or meet those expectations feel out-of-place.

Because of this, I think it's possible to draw a line between what should be consistent across platforms and what should be consistent to a platform. To that end, I humbly endorse an option to place the close button on the left side, please. 🙏 😄

But, if it doesn't make it in, I've lived with it this long because the beauty and aesthetic of the rest of the theme are more valuable to me than the location of the close tab button.

@simurai
Copy link
Contributor

simurai commented Mar 29, 2018

I humbly endorse an option to place the close button on the left side, please. 🙏 😄

Ok, one can't say no to being asked that politely. 😄 There is now a PR #253 that should be available in Atom 1.27.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants