Emit a deprecation warning when accessing deprecated views via $::view

atom-archive · Jan 2, 2015 · 814ae2e · 814ae2e
1 parent 5456a32
commit 814ae2e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
     "grunt-atomdoc": "^1.0.0"
   },
   "dependencies": {
-    "grim": "^0.12.0",
+    "grim": "^0.13.0",
     "underscore-plus": "1.x"
   }
 }
diff --git a/src/space-pen.coffee b/src/space-pen.coffee
@@ -282,7 +282,11 @@ class Builder
 # jQuery extensions
 
 $.fn.view = ->
-  @[0]?.spacePenView
+  if element = @[0]
+    if element.__spacePenView?
+      viewConstructorName = element.__spacePenView.constructor.name
+      Grim?.deprecate("Accessing `#{viewConstructorName}` via `$::view()` is deprecated. Use the raw DOM node or underlying model object instead.")
+    element.spacePenView
 
 $.fn.views = -> @toArray().map (elt) ->
   $elt = $(elt)