This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
add relative prefix to build script command #34
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Node 8.9.3 and Rust 1.24.1.
When running
npm install
fromxray_electron
as suggested in contributing.md, the napi.js script triggered during the Cargo compilation ofxray_node
didn't look fortarget
at the outside layer, where the code is built, but for atarget
folder inside thexray_node
folder. Printingpwd
from the child process cp confirms that it is executing inside thexray_node
folder.Adding this relative path fixed the issue for me. I'm not sure why
{ stdio: 'inherit' }
doesn't work in the same way between lines 53 and 54. (Am new to rust and Cargo, is it something there?)I also added two
break
statements to the other cases for execution clarity in the switch statement.