Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run ./test.sh from bin folder #44

Closed
wants to merge 1 commit into from

Conversation

sashao
Copy link

@sashao sashao commented Nov 10, 2021

If someone like me goes to bin folder and runs "./test.sh ../assets/test/scientists.jpg", file_not_found error will occur.
Fixed RUSTFACE_HOME detection when script runs from other places.

If someone like me goes to bin folder and runs "./test.sh ../assets/test/scientists.jpg", file_not_found error will occur.
Fixed RUSTFACE_HOME detection when script runs from other places.
@jjhbw
Copy link
Collaborator

jjhbw commented Nov 10, 2021

Thanks for bringing this to my attention. I personally never use this script, because it doesn't really add anything IMO.

Whenever i'm checking out a piece of software, I never run scripts like this without reading them first (as IMO everyone should), which kind of negates the potential convenience it offers.

Isn't it way easier to just put the below command in the README, and remove this test script?

cargo run --release --example image_demo model/seeta_fd_frontal_v1.0.bin assets/test/scientists.jpg

This would be far more transparent.

@jjhbw
Copy link
Collaborator

jjhbw commented Nov 10, 2021

I decided to remove test.sh, as it isn't really needed and unnecessarily confusing (93c97ed). Thanks for bringing this to my attention!

@jjhbw jjhbw closed this Nov 10, 2021
@sashao sashao deleted the patch-1 branch November 23, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants