Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions deploy fail #101

Closed
DanielKotik opened this issue Nov 22, 2021 · 0 comments · Fixed by #131
Closed

GitHub Actions deploy fail #101

DanielKotik opened this issue Nov 22, 2021 · 0 comments · Fixed by #131
Assignees
@DanielKotik
Labels
bug Something isn't working not critical

Comments

@DanielKotik
Copy link
Contributor

DanielKotik commented Nov 22, 2021 •
edited
Loading

When a review is approved, the build-and-deploy-pages pipeline gets triggered but fails with

build-and-deploy-pages
Action failed with "not found deploy key or tokens"

The expected behaviour is, that this pipeline is skipped when a PR gets approved and only gets triggered, when the actual merge happens. Even better would be, if building the pages gets triggered when a PR is created and build+deploy finally on merge.
@DanielKotik DanielKotik added bug Something isn't working not critical labels Nov 22, 2021
@DanielKotik DanielKotik self-assigned this Nov 22, 2021
DanielKotik added a commit to DanielKotik/atoMEC that referenced this issue Mar 7, 2022
@DanielKotik
Avoids pipeline trigger on approved reviews:
3f18fda 
If the review is approved, a run of the pipeline was triggered but
failed due to insufficient rights from the forked repository. There is
actually no need for an extra run of the pipeline once a review is
approved since a push to master or develop is likely to follow. This
merge/push is done with sufficient rights of the repositories owners.

Fixes atomec-project#101
@DanielKotik DanielKotik mentioned this issue Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielKotik DanielKotik

Labels
bug Something isn't working not critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid pipeline trigger on approved reviews: DanielKotik/atoMEC
1 participant
@DanielKotik