fix: change lineNumbers regex to respect positioning/existence of showLineNumbers{x}
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rehype-pretty-code canceled.
|
atomiks
reviewed
Apr 18, 2023
src/index.js
Outdated
| @@ -198,7 +198,7 @@ export default function rehypePrettyCode(options = {}) { | |||
| meta = meta.replace(tiltleMatch?.[0] ?? '', ''); | |||
|
|
|||
| const lineNumbers = meta | |||
| ? rangeParser(meta.match(/{(.*)}/)?.[1] ?? '') | |||
| ? rangeParser(meta.match(/(?<!\S){(.*?)}/)?.[1] ?? '') | |||
There was a problem hiding this comment.
I think this breaks in older Safaris
There was a problem hiding this comment.
Oh shoot, because of the negative lookbehind huh.
What about (?:^|\s){(.*?)}
|
tests did seem to pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
showLineNumbersexists with a value to start at, likeshowLineNumbers{3}, the line highlighter potentially grabs that number instead of the appropriate line highlight group, causing line highlights to not function correctly.The new regex essentially checks to see if there are any characters before the
{other than white space and filters them out. If there is a white space before the{, it's the correct group for line highlights.If you run the additional test, but without the changes in
src/index.js, the test fails. It then passes with the changes.