New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 (WIP) #46
Conversation
@KubaJastrz, the types need some updating, are you able to edit them with the correct ones |
Sure, I'll check it out Edit - there: #47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs docs for <TippyGroup />
* Add typings for V2 * Fix component types
@KubaJastrz just noticed for the types: |
It's a combination of both. I've missed it yesterday Edit: added in #48 |
* Add missing TippyGroup types * Fix TippyGroup types
Upgrading to
tippy.js@4
once it's releasedHighlights:
findDOMNode()
, now usingcloneElement
with aref
. Ok, I don't know why I didn't see this being viable before, or anyone else pointing it out 馃槅. To wrap components, you'll need to useforwardRef()
. Sincestyled-components@4
uses this already it's pretty seamless for most use cases.trigger="manual"
, it's added for you ifisVisible
is specified as a propAdditional export(s):
tippy.group()
wrapper