Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getContentBuffer method to File #476

Merged
merged 3 commits into from Feb 21, 2019
Merged

Conversation

jessitron
Copy link
Contributor

this gives us an abstraction that makes uploads to S3 work.

Jessica Kerr added 3 commits February 21, 2019 15:39
@cdupuis cdupuis added enhancement changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals labels Feb 21, 2019
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atomist-bot atomist-bot merged commit 0064429 into master Feb 21, 2019
@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the nortissej/contentBuffer branch February 21, 2019 22:18
atomist-bot added a commit that referenced this pull request Feb 21, 2019
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals changelog:added Add this issue or pull request to added changelog section enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants