Refactor core APIs for new method naming standards.

core/src/main/java/io/atomix/cluster/ClusterService.java

@@ -30,7 +30,7 @@ public interface ClusterService extends ListenerService<ClusterEvent, ClusterEve
    *
    * @return local controller node
    */
-  Node getLocalNode();
+  Node localNode();
 
   /**
    * Returns the set of current cluster members.

core/src/main/java/io/atomix/cluster/Node.java

@@ -68,20 +68,20 @@ public boolean isReady() {
    *
    * @return instance identifier
    */
-  NodeId getNodeId();
+  NodeId nodeId();
 
   /**
    * Returns the IP address of the controller instance.
    *
    * @return IP address
    */
-  InetAddress getInetAddress();
+  InetAddress getAddress();
 
   /**
    * Returns the TCP port on which the node listens for connections.
    *
    * @return TCP port
    */
-  int getTcpPort();
+  int getPort();
 
 }

core/src/main/java/io/atomix/cluster/Partition.java

@@ -28,7 +28,7 @@ public interface Partition {
    *
    * @return partition identifier
    */
-  PartitionId getPartitionId();
+  PartitionId partitionId();
 
   /**
    * Returns the controller nodes that are members of this partition.

core/src/main/java/io/atomix/cluster/PartitionId.java

@@ -49,7 +49,7 @@ public static PartitionId from(int id) {
    * @return number
    */
   public int asInt() {
-    return value();
+    return id();
   }
 
   @Override

core/src/main/java/io/atomix/cluster/messaging/MessageSubject.java

@@ -28,24 +28,29 @@
  */
 public final class MessageSubject {
 
-  private final String value;
+  private final String name;
 
-  public MessageSubject(String value) {
-    this.value = Preconditions.checkNotNull(value);
+  public MessageSubject(String name) {
+    this.name = Preconditions.checkNotNull(name);
   }
 
-  public String value() {
-    return value;
+  /**
+   * Returns the subject name.
+   *
+   * @return the message subject name
+   */
+  public String name() {
+    return name;
   }
 
   @Override
   public String toString() {
-    return value;
+    return name;
   }
 
   @Override
   public int hashCode() {
-    return value.hashCode();
+    return name.hashCode();
   }
 
   @Override
@@ -60,11 +65,11 @@ public boolean equals(Object obj) {
       return false;
     }
     MessageSubject that = (MessageSubject) obj;
-    return Objects.equals(this.value, that.value);
+    return Objects.equals(this.name, that.name);
   }
 
   // for serializer
   protected MessageSubject() {
-    this.value = "";
+    this.name = "";
   }
 }

core/src/main/java/io/atomix/leadership/Leader.java

@@ -49,7 +49,7 @@ public Leader(NodeId nodeId, long term, long termStartTime) {
    *
    * @return node identifier
    */
-  public NodeId getNodeId() {
+  public NodeId nodeId() {
     return nodeId;
   }
 
@@ -58,7 +58,7 @@ public NodeId getNodeId() {
    *
    * @return leader term
    */
-  public long getTerm() {
+  public long term() {
     return term;
   }
 
@@ -67,7 +67,7 @@ public long getTerm() {
    *
    * @return current leader term start time
    */
-  public long getTimestamp() {
+  public long timestamp() {
     return termStartTime;
   }
 

core/src/main/java/io/atomix/leadership/Leadership.java

@@ -56,7 +56,7 @@ public String topic() {
    * @return leader node identifier; will be null if there is no leader
    */
   public NodeId leaderNodeId() {
-    return leader == null ? null : leader.getNodeId();
+    return leader == null ? null : leader.nodeId();
   }
 
   /**

core/src/main/java/io/atomix/primitives/DistributedPrimitive.java

@@ -138,14 +138,14 @@ enum Status {
    *
    * @return name
    */
-  String getName();
+  String name();
 
   /**
    * Returns the type of primitive.
    *
    * @return primitive type
    */
-  Type getPrimitiveType();
+  Type primitiveType();
 
   /**
    * Purges state associated with this primitive.

core/src/main/java/io/atomix/primitives/Synchronous.java

@@ -32,13 +32,13 @@ public Synchronous(T primitive) {
   }
 
   @Override
-  public String getName() {
-    return primitive.getName();
+  public String name() {
+    return primitive.name();
   }
 
   @Override
-  public Type getPrimitiveType() {
-    return primitive.getPrimitiveType();
+  public Type primitiveType() {
+    return primitive.primitiveType();
   }
 
   @Override

core/src/main/java/io/atomix/primitives/counter/AsyncAtomicCounter.java

@@ -26,7 +26,7 @@
 public interface AsyncAtomicCounter extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.COUNTER;
   }
 

core/src/main/java/io/atomix/primitives/counter/AtomicCounter.java

@@ -23,7 +23,7 @@
 public interface AtomicCounter extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.COUNTER;
   }
 

core/src/main/java/io/atomix/primitives/elector/AsyncLeaderElector.java

@@ -47,7 +47,7 @@
 public interface AsyncLeaderElector extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.LEADER_ELECTOR;
   }
 

core/src/main/java/io/atomix/primitives/elector/LeaderElector.java

@@ -30,7 +30,7 @@
 public interface LeaderElector extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.LEADER_ELECTOR;
   }
 

core/src/main/java/io/atomix/primitives/generator/AsyncAtomicIdGenerator.java

@@ -26,7 +26,7 @@
 public interface AsyncAtomicIdGenerator extends DistributedPrimitive {
 
   @Override
-  default Type getPrimitiveType() {
+  default Type primitiveType() {
     return Type.ID_GENERATOR;
   }
 

core/src/main/java/io/atomix/primitives/generator/AtomicIdGenerator.java

@@ -23,7 +23,7 @@
 public interface AtomicIdGenerator extends DistributedPrimitive {
 
   @Override
-  default Type getPrimitiveType() {
+  default Type primitiveType() {
     return Type.ID_GENERATOR;
   }
 

core/src/main/java/io/atomix/primitives/lock/AsyncDistributedLock.java

@@ -27,7 +27,7 @@
 public interface AsyncDistributedLock extends DistributedPrimitive {
 
   @Override
-  default Type getPrimitiveType() {
+  default Type primitiveType() {
     return Type.LOCK;
   }
 

core/src/main/java/io/atomix/primitives/lock/DistributedLock.java

@@ -25,7 +25,7 @@
 public interface DistributedLock extends DistributedPrimitive {
 
   @Override
-  default Type getPrimitiveType() {
+  default Type primitiveType() {
     return Type.LOCK;
   }
 

core/src/main/java/io/atomix/primitives/map/AsyncAtomicCounterMap.java

@@ -26,7 +26,7 @@
 public interface AsyncAtomicCounterMap<K> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.COUNTER_MAP;
   }
 

core/src/main/java/io/atomix/primitives/map/AsyncConsistentMap.java

@@ -58,7 +58,7 @@
 public interface AsyncConsistentMap<K, V> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.CONSISTENT_MAP;
   }
 

core/src/main/java/io/atomix/primitives/map/AsyncConsistentMultimap.java

@@ -39,7 +39,7 @@
 public interface AsyncConsistentMultimap<K, V> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return Type.CONSISTENT_MULTIMAP;
   }
 

core/src/main/java/io/atomix/primitives/map/AtomicCounterMap.java

@@ -23,7 +23,7 @@
 public interface AtomicCounterMap<K> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.COUNTER_MAP;
   }
 

core/src/main/java/io/atomix/primitives/map/EventuallyConsistentMap.java

@@ -44,7 +44,7 @@
 public interface EventuallyConsistentMap<K, V> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.EVENTUALLY_CONSISTENT_MAP;
   }
 

core/src/main/java/io/atomix/primitives/map/impl/DefaultAtomicCounterMap.java

@@ -124,7 +124,7 @@ private <T> T complete(CompletableFuture<T> future) {
       Thread.currentThread().interrupt();
       throw new ConsistentMapException.Interrupted();
     } catch (TimeoutException e) {
-      throw new ConsistentMapException.Timeout(getName());
+      throw new ConsistentMapException.Timeout(name());
     } catch (ExecutionException e) {
       Throwables.propagateIfPossible(e.getCause());
       throw new ConsistentMapException(e.getCause());

core/src/main/java/io/atomix/primitives/map/impl/DefaultConsistentMap.java

@@ -228,7 +228,7 @@ private <T> T complete(CompletableFuture<T> future) {
       Thread.currentThread().interrupt();
       throw new ConsistentMapException.Interrupted();
     } catch (TimeoutException e) {
-      throw new ConsistentMapException.Timeout(getName());
+      throw new ConsistentMapException.Timeout(name());
     } catch (ExecutionException e) {
       Throwables.propagateIfPossible(e.getCause());
       throw new ConsistentMapException(e.getCause());

core/src/main/java/io/atomix/primitives/queue/WorkQueue.java

@@ -43,7 +43,7 @@
 public interface WorkQueue<E> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.WORK_QUEUE;
   }
 

core/src/main/java/io/atomix/primitives/set/AsyncDistributedSet.java

@@ -34,7 +34,7 @@
 public interface AsyncDistributedSet<E> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.SET;
   }
 

core/src/main/java/io/atomix/primitives/value/AsyncAtomicValue.java

@@ -33,7 +33,7 @@
 public interface AsyncAtomicValue<V> extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.VALUE;
   }
 

core/src/main/java/io/atomix/protocols/raft/protocol/messaging/RaftClientCommunicator.java

@@ -60,7 +60,7 @@ public RaftClientCommunicator(String prefix, Serializer serializer, ClusterCommu
   }
 
   private <T, U> CompletableFuture<U> sendAndReceive(MessageSubject subject, T request, MemberId memberId) {
-    return clusterCommunicator.sendAndReceive(request, subject, serializer::encode, serializer::decode, NodeId.nodeId(memberId.value()));
+    return clusterCommunicator.sendAndReceive(request, subject, serializer::encode, serializer::decode, NodeId.nodeId(memberId.id()));
   }
 
   @Override

core/src/main/java/io/atomix/protocols/raft/protocol/messaging/RaftServerCommunicator.java

@@ -77,7 +77,7 @@ public RaftServerCommunicator(String prefix, Serializer serializer, ClusterCommu
   }
 
   private <T, U> CompletableFuture<U> sendAndReceive(MessageSubject subject, T request, MemberId memberId) {
-    return clusterCommunicator.sendAndReceive(request, subject, serializer::encode, serializer::decode, NodeId.nodeId(memberId.value()));
+    return clusterCommunicator.sendAndReceive(request, subject, serializer::encode, serializer::decode, NodeId.nodeId(memberId.id()));
   }
 
   @Override
@@ -152,7 +152,7 @@ public CompletableFuture<AppendResponse> append(MemberId memberId, AppendRequest
 
   @Override
   public void publish(MemberId memberId, PublishRequest request) {
-    clusterCommunicator.unicast(request, context.publishSubject(request.getSession()), serializer::encode, NodeId.nodeId(memberId.value()));
+    clusterCommunicator.unicast(request, context.publishSubject(request.getSession()), serializer::encode, NodeId.nodeId(memberId.id()));
   }
 
   @Override

core/src/main/java/io/atomix/transaction/TransactionContext.java

@@ -40,7 +40,7 @@
 public interface TransactionContext extends DistributedPrimitive {
 
   @Override
-  default DistributedPrimitive.Type getPrimitiveType() {
+  default DistributedPrimitive.Type primitiveType() {
     return DistributedPrimitive.Type.TRANSACTION_CONTEXT;
   }
 
@@ -49,7 +49,7 @@ default DistributedPrimitive.Type getPrimitiveType() {
    *
    * @return transaction id
    */
-  TransactionId getTransactionId();
+  TransactionId transactionId();
 
   /**
    * Returns if this transaction context is open.

core/src/main/java/io/atomix/transaction/TransactionLog.java

@@ -53,7 +53,7 @@ public TransactionId transactionId() {
    *
    * @return the transaction lock version
    */
-  public long getVersion() {
+  public long version() {
     return version;
   }
 
@@ -62,7 +62,7 @@ public long getVersion() {
    *
    * @return a list of transaction log records
    */
-  public List<T> getRecords() {
+  public List<T> records() {
     return records;
   }