Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change owner to root #76

Closed
paulmenzel opened this issue Aug 27, 2019 · 2 comments
Closed

Do not change owner to root #76

paulmenzel opened this issue Aug 27, 2019 · 2 comments

Comments

@paulmenzel
Copy link

For users wanting to build Atop themselves, or for build tests with unprivileged users, explicitly calling chown root … is problematic.

atop/Makefile

Lines 146 to 159 in 3e0b68c

cp atop $(DESTDIR)$(BINPATH)/atop
chown root $(DESTDIR)$(BINPATH)/atop
chmod 04711 $(DESTDIR)$(BINPATH)/atop
ln -sf atop $(DESTDIR)$(BINPATH)/atopsar
cp atopacctd $(DESTDIR)$(SBINPATH)/atopacctd
chown root $(DESTDIR)$(SBINPATH)/atopacctd
chmod 0700 $(DESTDIR)$(SBINPATH)/atopacctd
cp atopgpud $(DESTDIR)$(SBINPATH)/atopgpud
chown root $(DESTDIR)$(SBINPATH)/atopgpud
chmod 0700 $(DESTDIR)$(SBINPATH)/atopgpud
cp atop $(DESTDIR)$(BINPATH)/atop-$(VERS)
ln -sf atop-$(VERS) $(DESTDIR)$(BINPATH)/atopsar-$(VERS)
cp atopconvert $(DESTDIR)$(BINPATH)/atopconvert
chown root $(DESTDIR)$(BINPATH)/atopconvert

I think, it’s common practice to keep the owner of binaries the same as the build user.

@Atoptool
Copy link
Owner

Atoptool commented Aug 3, 2021

Issue solved.

@Atoptool Atoptool closed this as completed Aug 3, 2021
@paulmenzel
Copy link
Author

Thank you.

Resolved by commit 28201da (Do not change owner to root in Makefile (issue #76)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants