Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #101 add get keys function #102

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Closes #101 add get keys function #102

merged 4 commits into from
Apr 26, 2024

Conversation

tamarasenior
Copy link
Collaborator

@tamarasenior tamarasenior commented Apr 12, 2024 •
edited

Closes #101

@tamarasenior tamarasenior self-assigned this Apr 12, 2024
@tamarasenior tamarasenior marked this pull request as ready for review April 16, 2024 12:06
anajens
anajens reviewed Apr 16, 2024
View reviewed changes
R/metacore.R Show resolved Hide resolved
anajens
anajens approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@anajens anajens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tired this out and it's working well! Please add some unit test(s) before merging.

tamarasenior and others added 2 commits April 19, 2024 14:26
@tamarasenior @anajens
Update R/metacore.R
43a67e7 
Co-authored-by: Jana Stoilova <43623360+anajens@users.noreply.github.com>
@seniort
Write unit tests
ced13e3
@tamarasenior tamarasenior changed the title #101 add get keys function Closes #101 add get keys function Apr 25, 2024
@tamarasenior tamarasenior linked an issue Apr 25, 2024 that may be closed by this pull request
add get_key function #101
Closed
@statasaurus statasaurus merged commit b9fb613 into dev Apr 26, 2024
5 checks passed
@statasaurus statasaurus deleted the 101-add-get_key-function branch April 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anajens anajens anajens approved these changes

Assignees

@tamarasenior tamarasenior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add get_key function
4 participants
@tamarasenior @anajens @statasaurus @seniort