Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data issue #2

Closed
meadow163 opened this issue Mar 14, 2022 · 6 comments
Closed

data issue #2

meadow163 opened this issue Mar 14, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@meadow163
Copy link

Hi Ian Shih,
Thank for your amazing job.
I would like to train this model using my data, could you tell my how I make the data like your 'train_seg2_512.pkl' data?
I will appreciate that if I can your reply.

Thanks.

@atosystem
Copy link
Owner

@meadow163 Thanks for using Theme Transformer!

So I added some codes and information for generating your own training data. (See preprocess), or you can see this reply also (#1 (comment)).

@chunniunai220ml
Copy link

@atosystem
Hi, Thank for your share for your novel idea. I would like to know how to test my data(just convert mp3 to midi)?
and how to get the tempo_json.dict? I did not get it in the POP909 dataset

@atosystem
Copy link
Owner

atosystem commented Mar 17, 2022

@chunniunai220ml

  1. Actually, I'm not quite sure what you mean by test our data(just convert mp3 to midi)?
    Do you mean that your test themes are in .mp3 format and you want to apply it to Theme Transformer?

  2. As for tempo_json.dict, it records the main tempo in POP909. I use it as the start tokens for the models. If you are using your own themes, you can assign the tempo manually as you like.

@chunniunai220ml
Copy link

chunniunai220ml commented Mar 17, 2022

@atosystem

Thank for your reply!
question1. I mean that i have converte the mp3 to the midi format by the webpage :https://www.bearaudiotool.com/zh/mp3-to-midi#google_vignette
and could you tell me what tools you uesed to convert? like your reply in the #issue 1
1647499274(1)

@atosystem
Copy link
Owner

@chunniunai220ml

So you are asking about converting midi files into the format I showed in the picture (Containing 3 tracks: MELODY, PIANO and Theme info track), right?

The melody and piano tracks come from POP909 directly, as for the theme info track, we used the contrastive learning method for theme retrieval to marked the theme occurrences (as mentioned in the paper).

So, in your case, the midi files are transcribed from your mp3 file. Hence, your might need tools to separate melody from the accompaniment (i.e. the PIANO track). A naive way of doing this is to simply consider the notes with the highest pitch on every onset time of the midi file as the melody notes. For more complicated methods, you might need to survey some paper for melody separation or perhaps some DAW software may have this function.

@atosystem
Copy link
Owner

@chunniunai220ml
I will close this issue since it has been a long time for no further discussion.

@atosystem atosystem added the documentation Improvements or additions to documentation label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants