Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data process in prepareDataPkl.py #7

Closed
ZZDoog opened this issue Nov 30, 2022 · 1 comment
Closed

Data process in prepareDataPkl.py #7

ZZDoog opened this issue Nov 30, 2022 · 1 comment

Comments

@ZZDoog
Copy link

ZZDoog commented Nov 30, 2022

Hi, Ian! Thank you for your excellent job.
I want to process my data from *.midi to *.pkl using your code prepareDataPkl.py lately, and maybe I found some little errors in it.
in line 20 - 25

all_mids = sorted(glob.glob(MIDI_FILES))

for _midiFile in all_midis:
    # convert midi files to token representation and save as .pkl file
    output_pkl_fp = midifp.replace(".mid",".pkl")
    remi_seq = myvocab.midi2REMI(midifp,include_bridge=False,bar_first=False,verbose=False)

maybe it's for _midiFile in all_mids: and output_pkl_fp = _midifile.replace(".mid",".pkl")?
And in line 40 and line 45, the definition of training_data is missing.

@atosystem
Copy link
Owner

@ZZDoog Thanks for pointing out the errors.
I have fixed the bugs and merged update the repo! (#8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants