Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dboolean and use bool where appropriate #106

Closed
atsb opened this issue Dec 28, 2022 · 2 comments
Closed

Remove dboolean and use bool where appropriate #106

atsb opened this issue Dec 28, 2022 · 2 comments

Comments

@atsb
Copy link
Owner

atsb commented Dec 28, 2022

I fixed the console because of this, however there are hundreds of instances of dboolean where there should be either a bool and an int (depending on what it is used for).

Sometimes a dboolean function will not return a real boolean but an integer value because dboolean is mapped to an int. This needs to be cleared up and tested.

This issue is to track this change.

atsb added a commit that referenced this issue Dec 28, 2022
@atsb
Copy link
Owner Author

atsb commented Dec 28, 2022

I've made a branch about this. It works flawlesslly on Windows and all other systems (except Unixes that have a LoadLeaf error). This is basically what Choco does and I can see why.

Your change Wolfy for the library, was a damn good one. Although we will need to adapt it a bit for these corner cases, you uncovered a whole load of bad code that needed changing. This wouldn't have been discovered without your library.

@atsb
Copy link
Owner Author

atsb commented Dec 29, 2022

Done in stable.

@atsb atsb closed this as completed Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant