Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch xinput to SDL_GameController #42

Closed
Wolf3s opened this issue Nov 17, 2022 · 6 comments
Closed

Switch xinput to SDL_GameController #42

Wolf3s opened this issue Nov 17, 2022 · 6 comments
Labels
enhancement New feature or request
Milestone
3.6.6

Comments

@Wolf3s
Copy link
Collaborator

Wolf3s commented Nov 17, 2022

No description provided.

@atsb
Copy link
Owner

atsb commented Nov 17, 2022

Good idea! SDL_GameController is multi platform and supports most of the popular controllers. Xinput is windows only and has a disgusting hacky API. I’ll get started with this

@Wolf3s
Copy link
Collaborator Author

Wolf3s commented Nov 17, 2022

Good idea! SDL_GameController is multi platform and supports most of the popular controllers. Xinput is windows only and has a disgusting hacky API. I’ll get started with this

I tried sometime once but i didn't make it :(

@atsb
Copy link
Owner

atsb commented Nov 17, 2022

No worries, I'll take care of it. Good news is that, without that XInput stuff, we can remove the gamepad specific menu entries as I'll use SDL_Joystick, so the gamepad will use the same sensitivity as the mouse. Nice and easy

@atsb
Copy link
Owner

atsb commented Nov 17, 2022

So I'm taking this from one of my other source ports (Pooch). The implementation there goes back to WinMBF and is super simple and fits right into the EX+ codebase. Some features may not be completely 100% the same, but this can be done after I get it working. I'll do a PR once that happens and we can go from there.

@Wolf3s
Copy link
Collaborator Author

Wolf3s commented Nov 17, 2022

So I'm taking this from one of my other source ports (Pooch). The implementation there goes back to WinMBF and is super simple and fits right into the EX+ codebase. Some features may not be completely 100% the same, but this can be done after I get it working. I'll do a PR once that happens and we can go from there.

i will try to see the launcher and support to linux

@atsb atsb added this to the 3.6.6 milestone Nov 22, 2022
@atsb atsb added the enhancement New feature or request label Nov 22, 2022
@Wolf3s Wolf3s changed the title Switch xinput to SDL_Joystick or SDL_GameControler Switch xinput to SDL_Joystick or SDL_GameController Dec 8, 2022
@Wolf3s Wolf3s changed the title Switch xinput to SDL_Joystick or SDL_GameController Switch xinput to SDL_GameController Dec 29, 2022
@Wolf3s Wolf3s mentioned this issue Jan 3, 2023
Merged
@Wolf3s Wolf3s pinned this issue Jan 6, 2023
@Wolf3s
Copy link
Collaborator Author

Wolf3s commented Jan 13, 2023

Closed the SDL_GameController is working although it has some minor glitches but i think it´s the conflict of the keyboard

@Wolf3s Wolf3s closed this as completed Jan 13, 2023
@Wolf3s Wolf3s unpinned this issue Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.6.6
Development

No branches or pull requests
2 participants
@atsb @Wolf3s