Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid or corrupted pad block when using AtClient.get #1071

Open
Xlin123 opened this issue Jun 20, 2023 · 1 comment
Open

Invalid or corrupted pad block when using AtClient.get #1071

Xlin123 opened this issue Jun 20, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Xlin123
Copy link
Member

Xlin123 commented Jun 20, 2023

Describe the bug

Using AtClient.get with shared symmetric keys will throw an invalid pad block exception.

This issue fixed the sync_service, changes for this will most likely need to be done in decryption_service.

Steps to reproduce

  1. Using Dart REPL, make sure to add dependency override for at_client using git
  2. use /get on a shared symmetric key
  3. error

Expected behavior

@gkc mentioned that he wanted at least a better exception but ideally the better solution would be the decrypted value for “our” copy, or an exception for “their” copy.

  1. alice retrieving their copy of the symmetric key that alice created for bob /get shared_key.bob@alice ==> should be decryptable by alice
  2. alice retrieving bob's copy of the symmetric key that alice created for bob /get @bob:shared_key@alice ==> not decryptable by alice, as alice encrypted this with bob's public key, and alice does not have bob's private key
  3. alice retrieving their copy of the symmetric key that bob created for alice/get @alice:shared_key@bob==> should be decryptable by alice
  4. alice retrieving bob's copy of the symmetric key that bob created for alice ==> this is not actually possible, it is only ever visible to bob in bob's atServer

Screenshots

image

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@Xlin123 Xlin123 added the bug Something isn't working label Jun 20, 2023
@Xlin123 Xlin123 self-assigned this Jun 20, 2023
@Xlin123
Copy link
Member Author

Xlin123 commented Jul 24, 2023

bug is fixed as of now, just need to write tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant