Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove privateKey references from at_lookup_impl and enforce at_chops #434

Open
murali-shris opened this issue Oct 19, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@murali-shris
Copy link
Member

Describe the bug

After at_chops and at_auth package implementation, private key should no longer be read from preferences and used in code.
Some code was left behind in atLookUp as a fallback mechanism if atChops is not set.
Changes to enforce atChops and remove privateKey from test files has been done in
atsign-foundation/at_client_sdk#1142

Steps to reproduce

n/a

Expected behavior

  • Remove call to authenticate method in AtLookupImpl --> _process
    else if (privateKey != null) {
    logger.finer('calling pkam without atchops');
    await authenticate(privateKey);
    }
  • Test the changes with at_client/at_client_mobile/at_onboarding_cli branches.
  • Do a sanity with mobile/CLI apps

Screenshots

No response

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@murali-shris murali-shris added the bug Something isn't working label Oct 19, 2023
@murali-shris murali-shris changed the title remove privateKey from at_lookup_impl and enforce at_chops remove privateKey references from at_lookup_impl and enforce at_chops Oct 19, 2023
@purnimavenkatasubbu
Copy link
Member

purnimavenkatasubbu commented Nov 27, 2023

Made the change and raised a draft PR and tested with all the apps and the cli apps. Moving it to next sprint for PR review and for publishing the package

@purnimavenkatasubbu
Copy link
Member

at_lookup:3.0.42 has been published to pub.dev

@murali-shris
Copy link
Member Author

Reopening the issue since it is a breaking change.
Change has to be done as part of major version release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants