Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch themes for packages #150

Open
9 tasks done
sarika01 opened this issue Aug 16, 2021 · 12 comments
Open
9 tasks done

Switch themes for packages #150

sarika01 opened this issue Aug 16, 2021 · 12 comments
Assignees
@sonle-geekyants @ayushkumarrojha
Labels
5 SP 5 Story Points - 3 Days Medium enhancement New feature or request PR43 Aug 2022 Sprint Planning PR44 Aug 2022 Sprint Planning PR45 Aug | Sept 2022 Sprint Planning
Projects
Sprint Planning Project Board

Comments

@sarika01
Copy link
Contributor

sarika01 commented Aug 16, 2021 •
edited by sonle-geekyants

The Flutter widgets provided through pub.dev should have the ability to switch themes between light and dark, controlled by the implementing app.

  • at_chat_flutter
  • at_common_flutter
  • at_contacts_flutter
  • at_contacts_group_flutter
  • at_events_flutter
  • at_follows_flutter
  • at_location_flutter
  • at_onboarding_flutter
  • at_backupkey_flutter
@sarika01 sarika01 created this issue from a note in Sprint Planning Project Board (Backlog) Aug 16, 2021
@sarika01 sarika01 added the enhancement New feature or request label Aug 16, 2021
@sarika01 sarika01 moved this from Backlog to PR19 in Sprint Planning Project Board Aug 23, 2021
@ksanty ksanty added 8 SP 8 Story Points - 5 Days Large PR19 Aug 2021 Sprint Planning labels Aug 23, 2021
@sarika01 sarika01 moved this from PR19 Core - 99 SP's to PR19 Apps - 130 SP's in Sprint Planning Project Board Aug 24, 2021
@sarika01
Copy link
Contributor Author

sarika01 commented Sep 7, 2021

Each package needs to be tested and published.

@sarika01 sarika01 added the PR20 Sept 2021 Sprint Planning label Sep 7, 2021
@sarika01 sarika01 moved this from PR19 Apps - 130 SP's | 111 + 16 Vel (3 SPs to plan) to PR20 Apps - in Sprint Planning Project Board Sep 7, 2021
@sarika01 sarika01 moved this from PR20 Apps - 90 SP's | 91 Vel (1 over) to PR21 Apps in Sprint Planning Project Board Sep 20, 2021
@ksanty ksanty added the PR21 Sept 2021 Sprint Planning label Sep 20, 2021
@sarika01 sarika01 moved this from PR21 Apps - 77 SP's | 79 Vel (2 over) to PR22 Apps in Sprint Planning Project Board Oct 4, 2021
@sarika01
Copy link
Contributor Author

sarika01 commented Oct 4, 2021 •
edited

Moving to backlog to give priority to other P1 issues.
Current changes available on: https://github.com/atsign-foundation/at_widgets/tree/feature/switch-theme

@sarika01 sarika01 removed PR19 Aug 2021 Sprint Planning PR20 Sept 2021 Sprint Planning PR21 Sept 2021 Sprint Planning labels Oct 4, 2021
@sarika01 sarika01 moved this from PR22 Apps to Backlog in Sprint Planning Project Board Oct 4, 2021
@sarika01 sarika01 removed the 8 SP 8 Story Points - 5 Days Large label Nov 30, 2021
@ksanty
Copy link
Member

ksanty commented Jul 28, 2022

@sonle-geekyants moving to high priority, so we can finish in PR43

@sachins-geekyants sachins-geekyants added 5 SP 5 Story Points - 3 Days Medium PR43 Aug 2022 Sprint Planning labels Aug 11, 2022
@sonle-geekyants
Copy link
Contributor

sonle-geekyants commented Aug 22, 2022 •
edited

I’ve fixed it on branch feature/switch-theme-new in the at_widgets. @ayushkumarrojha, could you please test it?

@sachins-geekyants
Copy link
Contributor

Needs validation and release.
Moving to next sprint.

@sachins-geekyants sachins-geekyants added 3 SP 3 Story Points - 1 Day Small and removed 5 SP 5 Story Points - 3 Days Medium labels Aug 22, 2022
@ksanty ksanty added the PR44 Aug 2022 Sprint Planning label Aug 23, 2022
@sachins-geekyants
Copy link
Contributor

@ayushkumarrojha can we test the packages for theme implementations ?

@ayushkumarrojha
Copy link

@sonle-geekyants @sachins-geekyants

We have validated the switch themes feature with the atwidget feature/switch-theme-new branch, below issues are observed for the same:

Observations:

  1. Red screen appears in at_follows_flutter when we tab on the screen
  2. at_onboarding flutter is not getting build
  3. Error message appears when Start onboarding button is clicked on macOS
  4. Some buttons and text are not visible in the below-attached screenshots.

PFA Screenshots for reference.
Switch new-20220906T060124Z-001.zip

Device Details:
Device: iPhone XR
OS: iOS 15.6

@sachins-geekyants
Copy link
Contributor

Assigning 5 SP and moving to next sprint.

@sachins-geekyants sachins-geekyants added 5 SP 5 Story Points - 3 Days Medium PR45 Aug | Sept 2022 Sprint Planning and removed 3 SP 3 Story Points - 1 Day Small labels Sep 6, 2022
@sachins-geekyants
Copy link
Contributor

Moving to requires validation.

@ayushkumarrojha
Copy link

@sonle-geekyants @sachins-geekyants

We have validated the switch themes feature with the atwidget feature/switch-theme-new branch, below issues are observed for the same:

Observations:

  1. We are not able to build at_contacts_flutter and at_onboarding-flutter
  2. Pop-up box text is not visible in at_location flutter

Screenshot 2022-10-04 at 12 55 56 pm

Device Details:
Device: iPhone XR
OS: iOS 15.6.1

@sonle-geekyants
Copy link
Contributor

sonle-geekyants commented Oct 6, 2022 •
edited

I have checked and I see that all issues are not occurring.
Popup has changed theme color and I still build successfully at_contacts_flutter and at_onboarding_flutter on iOS.
Could you please pull the newest code from branch "feature/switch-theme-new" and test it again? @ayushkumarrojha

Screen.Recording.2022-10-06.at.15.00.43.mov
Screen.Recording.2022-10-06.at.15.02.35.mov
Screen.Recording.2022-10-06.at.15.04.05.mov

@ayushkumarrojha
Copy link

@sonle-geekyants @sachins-geekyants

We have validated the switch themes feature with the atwidget feature/switch-theme-new branch, below issue is observed for the same:

Observations:

  1. Text is not displayed in Group Name text box while creating a new group in at_contacts_group_flutter
    File_000 (6)

Device Details:
Device: iPhone XR
OS: iOS 15.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonle-geekyants sonle-geekyants

@ayushkumarrojha ayushkumarrojha

Labels
5 SP 5 Story Points - 3 Days Medium enhancement New feature or request PR43 Aug 2022 Sprint Planning PR44 Aug 2022 Sprint Planning PR45 Aug | Sept 2022 Sprint Planning
Projects
No open projects
Sprint Planning Project Board
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sarika01 @ksanty @sachins-geekyants @sonle-geekyants @ayushkumarrojha