Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding - Capture which app was used to activate an @ sign #287

Closed
tinashe404 opened this issue Dec 1, 2021 · 12 comments
Closed

Onboarding - Capture which app was used to activate an @ sign #287

tinashe404 opened this issue Dec 1, 2021 · 12 comments
Assignees
Labels
1 SP 1 Story Point - Less than an hour Architecture Architecture Design blocker Flagging for resolution enhancement New feature or request PR29 Jan | Feb 2022 Sprint Planning PR30 Feb 2022 Sprint Planning PR31 Feb | Mar 2022 Sprint Planning PR32 Mar 2022 Sprint Planning PR33 Mar | Apr 2022 Sprint Planning PR34 Apr 2022 Sprint Planning PR35 Apr 2022 Sprint Planning PR36 Apr | May 2022 Sprint Planning PR43 Aug 2022 Sprint Planning

Comments

@tinashe404
Copy link
Member

tinashe404 commented Dec 1, 2021

Lead: @cconstab

We are currently looking into the developer program and how they earn commissions. Since we don't have in app purchases at the moment, in order to determine which apps should get commissions on paid atsigns, we need the onboarding widget to report which app was used to activate a paid atsign.

A suggestion from Ashish was that maybe it could be stored in the atsign secondary or atcompany secondary or hit a webhook so that he can know which app the atsign was activated in.

@tinashe404 tinashe404 added the enhancement New feature or request label Dec 1, 2021
@ksanty ksanty added blocker Flagging for resolution PR29 Jan | Feb 2022 Sprint Planning labels Jan 24, 2022
@gkc
Copy link
Contributor

gkc commented Jan 24, 2022

Decision to be pinned down and documented during this sprint

@yahu1031
Copy link
Member

yahu1031 commented Jan 24, 2022

Suggestions:

Idea 1

We can pass namespace to the req headers on API calls.

Idea 2

We can add a key in atKeys

{
  "aesPkamPublicKey": "...",
  "aesPkamPrivateKey": "...",
  "aesEncryptPublicKey": "...",
  "aesEncryptPrivateKey": "...",
  "selfEncryptionKey": "...",
  "@someatsign": "...",
  "activatedFrom": "namespace"
}

So when the atKeys file was generated, we can put another key like activatedFrom@someatsign and namespace as values in their secondary.

Drawback

Idea 2 will increase the storage(a little bit though).

@ksanty ksanty added the 5 SP 5 Story Points - 3 Days Medium label Jan 24, 2022
@sitaram-kalluri
Copy link
Member

During onboarding, After performing the initial auth, create a self key what will have namespace as a value and store into local-secondary and sync to remote secondary.
Have an API exposed which would the return value from the cloud secondary.

@ksanty ksanty added the PR30 Feb 2022 Sprint Planning label Feb 7, 2022
@VJag
Copy link
Member

VJag commented Feb 15, 2022

Solution 1:

API key per app/payee

Description:

Through some process, a developer logs into atsign.dev and gets an API key for his/her app. He also shares his details in order to be paid for the @sign commissions.

This key is then used to activate the @Signs. Since each app/payee is uniquely identified by a key, it is possible to identify and pay them.

In this approach securing the key is up to the developer. We will have the issue of someone decompiling the app and getting the key. Till we have an approach to solving that we have to use this approach.

Solution 2:

Extend activation API to include appName

Description:

In this approach, we need to extend the activation to include an additional parameter called "appName". it would the responsibility of the developer to pass the right value. We still need the keys for activation. But the only real use of the keys is to know that the app went through a certain process with us and probably even to rate limit etc..

Even in this approach, the developer needs to log in to the atsign.dev to get an API key. We still need a way for the developer to share the payment details. The only advantage here is probably we do not have to generate API keys per app.

activation API sample params:

Ex1:

newAtSign: atsita
appKey: k123
appName: buzz

Ex2:

newAtSign: atjagan
appKey: k123
appName: atmosphere

@VJag
Copy link
Member

VJag commented Feb 21, 2022

We have burned 5 story points and discussed the approach in an architecture call. This needs to be carried to the next sprint.

@ksanty ksanty added the PR31 Feb | Mar 2022 Sprint Planning label Feb 22, 2022
@ksanty ksanty added the PR32 Mar 2022 Sprint Planning label Mar 7, 2022
@ksanty ksanty added the PR33 Mar | Apr 2022 Sprint Planning label Mar 22, 2022
@ksanty ksanty added Architecture Architecture Design PR34 Apr 2022 Sprint Planning labels Apr 4, 2022
@ksanty ksanty added the PR35 Apr 2022 Sprint Planning label Apr 20, 2022
@ksanty ksanty added the PR36 Apr | May 2022 Sprint Planning label May 3, 2022
@murali-shris
Copy link
Member

moving this to backlog since issue has been carried over multiple sprints with no concrete approach

@gkc
Copy link
Contributor

gkc commented May 16, 2022

Should be able to make progress on this once atsign-foundation/at_server#686 has been implemented

@ksanty
Copy link
Member

ksanty commented Jul 28, 2022

@murali-shris above ticket is closed should we re-prioritize to high to try and finish PR43?

@murali-shris
Copy link
Member

@murali-shris above ticket is closed should we re-prioritize to high to try and finish PR43?

yes @ksanty

@athandle
Copy link

athandle commented Aug 2, 2022

@murali-shris do you have any update on this? How you are planning to do this?

@athandle athandle added the PR43 Aug 2022 Sprint Planning label Aug 8, 2022
@ksanty
Copy link
Member

ksanty commented Aug 10, 2022

@athandle can you please add outcome notes from today's architecture discussion, so we can reclassify priority? TY

@athandle
Copy link

@ksanty I am closing this ticket, will take care with https://github.com/atsign-company/at_handle_registrar_web/issues/140

@murali-shris murali-shris removed the 5 SP 5 Story Points - 3 Days Medium label Aug 12, 2022
@murali-shris murali-shris added the 1 SP 1 Story Point - Less than an hour label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 SP 1 Story Point - Less than an hour Architecture Architecture Design blocker Flagging for resolution enhancement New feature or request PR29 Jan | Feb 2022 Sprint Planning PR30 Feb 2022 Sprint Planning PR31 Feb | Mar 2022 Sprint Planning PR32 Mar 2022 Sprint Planning PR33 Mar | Apr 2022 Sprint Planning PR34 Apr 2022 Sprint Planning PR35 Apr 2022 Sprint Planning PR36 Apr | May 2022 Sprint Planning PR43 Aug 2022 Sprint Planning
Projects
None yet
Development

No branches or pull requests

9 participants